Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config option options.openLinksWithDefaultApp #11218

Closed
kulmann opened this issue Jul 18, 2024 · 0 comments · Fixed by #11238
Closed

Remove config option options.openLinksWithDefaultApp #11218

kulmann opened this issue Jul 18, 2024 · 0 comments · Fixed by #11238
Assignees
Labels
Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Jul 18, 2024

Describe the bug

We introduced the config option options.openLinksWithDefaultApp because we were afraid poeple would be confused that they are routed into the editor instead of seeing a single file public link in the files app first. Reality check: doesn't do any harm. So let's remove the config option and always route into the editor (which was the default behaviour of the config option).

Please remember to also remove the config option from the ocis config struct.

@kulmann kulmann added the Type:Bug Something isn't working label Jul 18, 2024
@AlexAndBear AlexAndBear self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants