Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions for disabled resources can be triggered via keyboard #11335

Closed
JammingBen opened this issue Aug 7, 2024 · 0 comments · Fixed by #11342
Closed

Actions for disabled resources can be triggered via keyboard #11335

JammingBen opened this issue Aug 7, 2024 · 0 comments · Fixed by #11342
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Collaborator

Describe the bug

Actions for disabled resources can be triggered via keyboard when navigating via tab and then pressing enter.

Steps to reproduce

  1. Upload a resource
  2. Disable that resource (can be done via code by returning true here: https://github.com/owncloud/web/blob/master/packages/web-pkg/src/components/FilesList/ResourceTable.vue#L549)
  3. Tab through the table
  4. As soon as you reach the pencil icon behind the resource name, press enter

Expected behavior

The action should not be focusable.

Actual behavior

The action can be focussed and performed. The same goes for the quick actions.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Aug 7, 2024
@JammingBen JammingBen moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Aug 7, 2024
@JammingBen JammingBen self-assigned this Aug 8, 2024
@JammingBen JammingBen moved this from Prio 3 or less to In progress in Infinite Scale Team Board Aug 8, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant