Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web doesn't react to 429 Too Many Requests in preview requests #11798

Closed
kulmann opened this issue Oct 18, 2024 · 1 comment · Fixed by #11813
Closed

Web doesn't react to 429 Too Many Requests in preview requests #11798

kulmann opened this issue Oct 18, 2024 · 1 comment · Fixed by #11813
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Oct 18, 2024

Describe the bug

When web makes requests to the previews webdav endpoint, a 429 Too Many Requests error can occur, possibly with a Retry-After header. Web doesn't react with retries at the moment.

Steps to reproduce

  1. Limit the thumbnail service to 2 concurrent preview image creations via THUMBNAILS_MAX_CONCURRENT_REQUESTS env var
  2. Request 10 images via file list

Expected behavior

The failed requests don't get retried.

Actual behavior

The web ui should react to 429 responses with retries.

Additional context

There are several places in the code / ui where preview requests happen and can fail:

  • files list
  • tiles view
  • right sidebar "Details" panel
  • preview app (especially in the pre-fetching of images)

All of those requests should be retried if they failed with a 429 status code. If the response has a Retry-After header it should be respected. If it's absent we should come up with a suitable retry offset on our own.

Backend context:

@kulmann kulmann added the Type:Bug Something isn't working label Oct 18, 2024
@kulmann kulmann changed the title Web doesn Web doesn't react to 429 Too Many Requests in preview requests Oct 18, 2024
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Oct 18, 2024
@kulmann kulmann moved this from Qualification to Prio 2 in Infinite Scale Team Board Oct 18, 2024
@kulmann
Copy link
Member Author

kulmann commented Oct 18, 2024

cc @JammingBen @rhafer

@JammingBen JammingBen self-assigned this Oct 18, 2024
@JammingBen JammingBen moved this from Prio 2 to In progress in Infinite Scale Team Board Oct 22, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants