Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove favorite button from file list #1987

Closed
LukasHirt opened this issue Sep 16, 2019 · 13 comments · Fixed by #3336
Closed

Remove favorite button from file list #1987

LukasHirt opened this issue Sep 16, 2019 · 13 comments · Fixed by #3336
Assignees
Labels
Status:Needs-Review Needs review from a maintainer Topic:good-first-issue beginner friendly task Type:Design
Milestone

Comments

@LukasHirt
Copy link
Contributor

image

@LukasHirt LukasHirt added the Topic:good-first-issue beginner friendly task label Sep 16, 2019
@PVince81
Copy link
Contributor

Alternative proposal: remove star icon from the rows and keep it in the sidebar.

How often does a user mark a file/folder as favorite ? I guess it happens even less often than sharing, so having it "hidden" in the sidebar would be ok.

cc @hurradieweltgehtunter as we talked about star icon this morning

@LukasHirt
Copy link
Contributor Author

LukasHirt commented Sep 22, 2019

Alternative proposal: remove star icon from the rows and keep it in the sidebar.

@PVince81 I'd be fine with that approach. Even though I like that user can get a quick overview in the folder if you have some favourite items in there or not. @pmaier1 @michaelstingl What do you think?

@LukasHirt
Copy link
Contributor Author

Even though I like that user can get a quick overview in the folder if you have some favourite items in there or not.

Maybe we could achieve this by adding some small icon next to the name same as in iOS app is the shared indicator.

@PVince81
Copy link
Contributor

PVince81 commented Sep 23, 2019

this depends how often the favorite feature is used and whether there is a use case where a user does want to see all favorites within a single folder.

in my case I only use favorites to have them as a shortcut to some folders and use the favorites panel to access them

maybe there are other non-shortcut use cases for favoriting files/folders ?

@PVince81 PVince81 added this to the backlog milestone Sep 24, 2019
@michaelstingl
Copy link
Contributor

I don't see the big value of displaying the favourite status in the file list. In the new iOS app, we display the favourite status in the details view, und there is a way to display all favourites.

favorites-detail-collection

@PVince81
Copy link
Contributor

@wuenschedesign

@wuenschedesign
Copy link

I tend to show a file in a file list as marked as favourite. I see no reason for not showing it to the user. BUT it’s not neccessary to give possibility to mark a file as favourite in the list overview, this can be done in a detailed view. I recommend to ask users to understand, what they are using the favourite for, so that we can decide to

@PVince81
Copy link
Contributor

PVince81 commented Nov 6, 2019

also proposed: to have the favorite icon to be part of the file actions box

@PVince81
Copy link
Contributor

PVince81 commented Nov 6, 2019

need better concept for indicators

@wuenschedesign
Copy link

Following the draft how to implement the favourite button. Note: I changed the originally colour yellow to action blue. Reason: yellow has low contrast and is hard to distinguish from background. Also the favorite icon works like a toggle switch and to make the UI more consistent, using grey and blue for toggle switches.

Folder not marked as favorite Folder marked as favorite
Favourite-01 Favourite-02

@PVince81
Copy link
Contributor

As discussed before, I think we all agreed to remove it from the file list but keep it in the sidebar ?
In the sidebar it must be clickable, need to check if that works.

@pmaier1 @LukasHirt

@PVince81 PVince81 changed the title Remove favorite button from sidebar Remove favorite button from file list Mar 16, 2020
@LukasHirt
Copy link
Contributor Author

I'd still keep it in the files list just in a different place. It could be e.g. in the Actions dropdown for the resources as "Mark as favourite" action.

@PVince81
Copy link
Contributor

PVince81 commented Mar 16, 2020

actions dropdown sounds like a good plan !

  • remove favorite from file list row
  • add "mark/unmark as favorite" in actions dropdown
  • check that the favorite icon in the context sidebar actually works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer Topic:good-first-issue beginner friendly task Type:Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants