Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test setup for all share scenarios #2896

Closed
2 tasks
PVince81 opened this issue Jan 20, 2020 · 7 comments
Closed
2 tasks

Test setup for all share scenarios #2896

PVince81 opened this issue Jan 20, 2020 · 7 comments
Assignees
@PVince81
Labels
QA:team

Comments

@PVince81
Copy link
Contributor

In order to be able to test the share indicators and share owner, we need to first have a setup available with all possible shares on which we can base the tests.

See owncloud/product#40 for a Python script that generates and illustrates all share scenarios we need to consider.

The idea is to:

  • create a skeleton folder with all those folders
  • implement a similar script in Javascript that creates the various shares. Maybe it could be a "Given" step called "Given a setup with all possible share scenarios"

We'll need this as a base to write acceptance tests for the share indicators, as we'll be asserting that the indicator and some information is visible in the share panel for specific folders.

@individual-it thoughts ?
@PVince81 PVince81 mentioned this issue Jan 20, 2020
Closed
2 tasks
@PVince81
Copy link
Contributor Author

Here I'm not sure how many of those scenarios are already covered in some scenario setups.
Also not sure if we should cover all the scenarios to be exhaustive or just pick the most relevant ones.

To me, ideal is that those tests are grouped together so we can refer back to the sharing scenarios.

@PVince81
Copy link
Contributor Author

We could also port over the scenarios that were created for OC 10: https://github.com/owncloud/core/pull/36572/files#diff-d5a7b47bf7d40f4780417db046827793R377

but would need to double check whether they cover all the scenarios that the script illustrates.

@PVince81
Copy link
Contributor Author

PVince81 commented Jan 20, 2020 •
edited
Loading

Here's the output of the script which also contains info about what shares were created:

### Setting up users ###
Deleting user "alice"
Creating user "alice"
Deleting user "bob"
Creating user "bob"
Deleting user "charlie"
Creating user "charlie"
Deleting user "dave"
Creating user "dave"

### Preparing share entries ###
Generating share entry from "alice":  {'base_path': 'alice2bob', 'path': 'alice2bob (IUP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP',)}
Generating sub-shares for:  {'base_path': 'alice2bob', 'path': 'alice2bob (IUP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP',)}
Generating share entry from "bob":  {'path': 'alice2bob (IUP)/alice2bob-sub (IUC)', 'type': 'dummy', 'kinds': ('IUC',)}
Generating share entry from "bob":  {'path': 'alice2bob (IUP)/alice2bob-sub-bob2charlie (IUC, OUP)', 'with': 'charlie', 'type': 'user', 'kinds': ('IUC', 'OUP')}
Generating share entry from "bob":  {'path': 'alice2bob (IUP)/alice2bob-sub+link (IUC, OLP)', 'type': 'link', 'kinds': ('IUC', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob (IUP)/alice2bob-sub-bob2charlie+link (IUC, OUP, OLP)', 'with': 'charlie', 'type': 'user', 'kinds': ('IUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob (IUP)/alice2bob-sub-bob2charlie+link (IUC, OUP, OLP)', 'type': 'link', 'kinds': ('IUC', 'OUP', 'OLP')}
Generating share entry from "alice":  {'base_path': 'alice2bob2charlie', 'path': 'alice2bob2charlie (IUP, OUP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP', 'OUP')}
Generating sub-shares for:  {'base_path': 'alice2bob2charlie', 'path': 'alice2bob2charlie (IUP, OUP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP', 'OUP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub (IUC, OUC)', 'type': 'dummy', 'kinds': ('IUC', 'OUC')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave (IUC, OUC, OUP)', 'with': 'dave', 'type': 'user', 'kinds': ('IUC', 'OUC', 'OUP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub+link (IUC, OUC, OLP)', 'type': 'link', 'kinds': ('IUC', 'OUC', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave+link (IUC, OUC, OUP, OLP)', 'with': 'dave', 'type': 'user', 'kinds': ('IUC', 'OUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave+link (IUC, OUC, OUP, OLP)', 'type': 'link', 'kinds': ('IUC', 'OUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'base_path': 'alice2bob2charlie', 'path': 'alice2bob2charlie (IUP, OUP)', 'type': 'user', 'with': 'charlie', 'kinds': ('IUP', 'OUP')}
Generating share entry from "alice":  {'base_path': 'alice2bob+link', 'path': 'alice2bob+link (IUP, OLP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob+link (IUP, OLP)', 'type': 'link', 'kinds': ('IUP', 'OLP')}
Generating sub-shares for:  {'base_path': 'alice2bob+link', 'path': 'alice2bob+link (IUP, OLP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob+link (IUP, OLP)/alice2bob+link-sub (IUC, OLC)', 'type': 'dummy', 'kinds': ('IUC', 'OLC')}
Generating share entry from "bob":  {'path': 'alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie (IUC, OLC, OUP)', 'with': 'charlie', 'type': 'user', 'kinds': ('IUC', 'OLC', 'OUP')}
Generating share entry from "bob":  {'path': 'alice2bob+link (IUP, OLP)/alice2bob+link-sub+link (IUC, OLC, OLP)', 'type': 'link', 'kinds': ('IUC', 'OLC', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie+link (IUC, OLC, OUP, OLP)', 'with': 'charlie', 'type': 'user', 'kinds': ('IUC', 'OLC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie+link (IUC, OLC, OUP, OLP)', 'type': 'link', 'kinds': ('IUC', 'OLC', 'OUP', 'OLP')}
Generating share entry from "alice":  {'base_path': 'alice2bob2charlie+link', 'path': 'alice2bob2charlie+link (IUP, OUP, OLP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie+link (IUP, OUP, OLP)', 'type': 'link', 'kinds': ('IUP', 'OUP', 'OLP')}
Generating sub-shares for:  {'base_path': 'alice2bob2charlie+link', 'path': 'alice2bob2charlie+link (IUP, OUP, OLP)', 'type': 'user', 'with': 'bob', 'kinds': ('IUP', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub (IUC, OLC, OUC)', 'type': 'dummy', 'kinds': ('IUC', 'OLC', 'OUC')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave (IUC, OLC, OUC, OUP)', 'with': 'dave', 'type': 'user', 'kinds': ('IUC', 'OLC', 'OUC', 'OUP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub+link (IUC, OLC, OUC, OLP)', 'type': 'link', 'kinds': ('IUC', 'OLC', 'OUC', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave+link (IUC, OLC, OUC, OUP, OLP)', 'with': 'dave', 'type': 'user', 'kinds': ('IUC', 'OLC', 'OUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave+link (IUC, OLC, OUC, OUP, OLP)', 'type': 'link', 'kinds': ('IUC', 'OLC', 'OUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'base_path': 'alice2bob2charlie+link', 'path': 'alice2bob2charlie+link (IUP, OUP, OLP)', 'type': 'user', 'with': 'charlie', 'kinds': ('IUP', 'OUP', 'OLP')}
Generating sub-shares for:  {'base_path': 'bob2charlie', 'path': 'bob2charlie (OUP)', 'type': 'user', 'with': 'charlie', 'kinds': ('OUP',)}
Generating share entry from "bob":  {'path': 'bob2charlie (OUP)/bob2charlie-sub (OUC)', 'type': 'dummy', 'kinds': ('OUC',)}
Generating share entry from "bob":  {'path': 'bob2charlie (OUP)/bob2charlie-sub-bob2dave (OUC, OUP)', 'with': 'dave', 'type': 'user', 'kinds': ('OUC', 'OUP')}
Generating share entry from "bob":  {'path': 'bob2charlie (OUP)/bob2charlie-sub+link (OUC, OLP)', 'type': 'link', 'kinds': ('OUC', 'OLP')}
Generating share entry from "bob":  {'path': 'bob2charlie (OUP)/bob2charlie-sub-bob2dave+link (OUC, OUP, OLP)', 'with': 'dave', 'type': 'user', 'kinds': ('OUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'bob2charlie (OUP)/bob2charlie-sub-bob2dave+link (OUC, OUP, OLP)', 'type': 'link', 'kinds': ('OUC', 'OUP', 'OLP')}
Generating sub-shares for:  {'base_path': 'bob2charlie+link', 'path': 'bob2charlie+link (OUP, OLP)', 'type': 'user', 'with': 'charlie', 'kinds': ('OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'bob2charlie+link (OUP, OLP)/bob2charlie+link-sub (OLC, OUC)', 'type': 'dummy', 'kinds': ('OLC', 'OUC')}
Generating share entry from "bob":  {'path': 'bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave (OLC, OUC, OUP)', 'with': 'dave', 'type': 'user', 'kinds': ('OLC', 'OUC', 'OUP')}
Generating share entry from "bob":  {'path': 'bob2charlie+link (OUP, OLP)/bob2charlie+link-sub+link (OLC, OUC, OLP)', 'type': 'link', 'kinds': ('OLC', 'OUC', 'OLP')}
Generating share entry from "bob":  {'path': 'bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave+link (OLC, OUC, OUP, OLP)', 'with': 'dave', 'type': 'user', 'kinds': ('OLC', 'OUC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave+link (OLC, OUC, OUP, OLP)', 'type': 'link', 'kinds': ('OLC', 'OUC', 'OUP', 'OLP')}
Generating sub-shares for:  {'base_path': 'link', 'path': 'link (OLP)', 'type': 'link', 'kinds': ('OLP',)}
Generating share entry from "bob":  {'path': 'link (OLP)/link-sub (OLC)', 'type': 'dummy', 'kinds': ('OLC',)}
Generating share entry from "bob":  {'path': 'link (OLP)/link-sub-bob2charlie (OLC, OUP)', 'with': 'charlie', 'type': 'user', 'kinds': ('OLC', 'OUP')}
Generating share entry from "bob":  {'path': 'link (OLP)/link-sub+link (OLC, OLP)', 'type': 'link', 'kinds': ('OLC', 'OLP')}
Generating share entry from "bob":  {'path': 'link (OLP)/link-sub-bob2charlie+link (OLC, OUP, OLP)', 'with': 'charlie', 'type': 'user', 'kinds': ('OLC', 'OUP', 'OLP')}
Generating share entry from "bob":  {'path': 'link (OLP)/link-sub-bob2charlie+link (OLC, OUP, OLP)', 'type': 'link', 'kinds': ('OLC', 'OUP', 'OLP')}

### Creating all shares ###
Logging in as user "alice"
Sharing "alice2bob (IUP)" from "alice" with user "bob"
Sharing "alice2bob2charlie (IUP, OUP)" from "alice" with user "bob"
Sharing "alice2bob+link (IUP, OLP)" from "alice" with user "bob"
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)" from "alice" with user "bob"
Logging in as user "bob"
Created "alice2bob (IUP)/alice2bob-sub (IUC)"
Sharing "alice2bob (IUP)/alice2bob-sub-bob2charlie (IUC, OUP)" from "bob" with user "charlie"
Sharing "alice2bob (IUP)/alice2bob-sub+link (IUC, OLP)" by "bob" with link
Sharing "alice2bob (IUP)/alice2bob-sub-bob2charlie+link (IUC, OUP, OLP)" from "bob" with user "charlie"
Sharing "alice2bob (IUP)/alice2bob-sub-bob2charlie+link (IUC, OUP, OLP)" by "bob" with link
Created "alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub (IUC, OUC)"
Sharing "alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave (IUC, OUC, OUP)" from "bob" with user "dave"
Sharing "alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub+link (IUC, OUC, OLP)" by "bob" with link
Sharing "alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave+link (IUC, OUC, OUP, OLP)" from "bob" with user "dave"
Sharing "alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave+link (IUC, OUC, OUP, OLP)" by "bob" with link
Sharing "alice2bob2charlie (IUP, OUP)" from "bob" with user "charlie"
Sharing "alice2bob+link (IUP, OLP)" by "bob" with link
Created "alice2bob+link (IUP, OLP)/alice2bob+link-sub (IUC, OLC)"
Sharing "alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie (IUC, OLC, OUP)" from "bob" with user "charlie"
Sharing "alice2bob+link (IUP, OLP)/alice2bob+link-sub+link (IUC, OLC, OLP)" by "bob" with link
Sharing "alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie+link (IUC, OLC, OUP, OLP)" from "bob" with user "charlie"
Sharing "alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie+link (IUC, OLC, OUP, OLP)" by "bob" with link
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)" by "bob" with link
Created "alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub (IUC, OLC, OUC)"
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave (IUC, OLC, OUC, OUP)" from "bob" with user "dave"
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub+link (IUC, OLC, OUC, OLP)" by "bob" with link
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave+link (IUC, OLC, OUC, OUP, OLP)" from "bob" with user "dave"
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave+link (IUC, OLC, OUC, OUP, OLP)" by "bob" with link
Sharing "alice2bob2charlie+link (IUP, OUP, OLP)" from "bob" with user "charlie"
Sharing "bob2charlie (OUP)" from "bob" with user "charlie"
Sharing "bob2charlie+link (OUP, OLP)" from "bob" with user "charlie"
Sharing "link (OLP)" by "bob" with link
Created "bob2charlie (OUP)/bob2charlie-sub (OUC)"
Sharing "bob2charlie (OUP)/bob2charlie-sub-bob2dave (OUC, OUP)" from "bob" with user "dave"
Sharing "bob2charlie (OUP)/bob2charlie-sub+link (OUC, OLP)" by "bob" with link
Sharing "bob2charlie (OUP)/bob2charlie-sub-bob2dave+link (OUC, OUP, OLP)" from "bob" with user "dave"
Sharing "bob2charlie (OUP)/bob2charlie-sub-bob2dave+link (OUC, OUP, OLP)" by "bob" with link
Created "bob2charlie+link (OUP, OLP)/bob2charlie+link-sub (OLC, OUC)"
Sharing "bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave (OLC, OUC, OUP)" from "bob" with user "dave"
Sharing "bob2charlie+link (OUP, OLP)/bob2charlie+link-sub+link (OLC, OUC, OLP)" by "bob" with link
Sharing "bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave+link (OLC, OUC, OUP, OLP)" from "bob" with user "dave"
Sharing "bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave+link (OLC, OUC, OUP, OLP)" by "bob" with link
Created "link (OLP)/link-sub (OLC)"
Sharing "link (OLP)/link-sub-bob2charlie (OLC, OUP)" from "bob" with user "charlie"
Sharing "link (OLP)/link-sub+link (OLC, OLP)" by "bob" with link
Sharing "link (OLP)/link-sub-bob2charlie+link (OLC, OUP, OLP)" from "bob" with user "charlie"
Sharing "link (OLP)/link-sub-bob2charlie+link (OLC, OUP, OLP)" by "bob" with link
Sharing "bob2charlie+link (OUP, OLP)" by "bob" with link

### Results ###
Logging in as user "bob"
Bob's tree: 
- /
- /alice2bob (IUP)
- /alice2bob (IUP)/alice2bob-sub (IUC)
- /alice2bob (IUP)/alice2bob-sub+link (IUC, OLP)
- /alice2bob (IUP)/alice2bob-sub-bob2charlie (IUC, OUP)
- /alice2bob (IUP)/alice2bob-sub-bob2charlie+link (IUC, OUP, OLP)
- /alice2bob+link (IUP, OLP)
- /alice2bob+link (IUP, OLP)/alice2bob+link-sub (IUC, OLC)
- /alice2bob+link (IUP, OLP)/alice2bob+link-sub+link (IUC, OLC, OLP)
- /alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie (IUC, OLC, OUP)
- /alice2bob+link (IUP, OLP)/alice2bob+link-sub-bob2charlie+link (IUC, OLC, OUP, OLP)
- /alice2bob2charlie (IUP, OUP)
- /alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub (IUC, OUC)
- /alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub+link (IUC, OUC, OLP)
- /alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave (IUC, OUC, OUP)
- /alice2bob2charlie (IUP, OUP)/alice2bob2charlie-sub-bob2dave+link (IUC, OUC, OUP, OLP)
- /alice2bob2charlie+link (IUP, OUP, OLP)
- /alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub (IUC, OLC, OUC)
- /alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub+link (IUC, OLC, OUC, OLP)
- /alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave (IUC, OLC, OUC, OUP)
- /alice2bob2charlie+link (IUP, OUP, OLP)/alice2bob2charlie+link-sub-bob2dave+link (IUC, OLC, OUC, OUP, OLP)
- /bob2charlie (OUP)
- /bob2charlie (OUP)/bob2charlie-sub (OUC)
- /bob2charlie (OUP)/bob2charlie-sub+link (OUC, OLP)
- /bob2charlie (OUP)/bob2charlie-sub-bob2dave (OUC, OUP)
- /bob2charlie (OUP)/bob2charlie-sub-bob2dave+link (OUC, OUP, OLP)
- /bob2charlie+link (OUP, OLP)
- /bob2charlie+link (OUP, OLP)/bob2charlie+link-sub (OLC, OUC)
- /bob2charlie+link (OUP, OLP)/bob2charlie+link-sub+link (OLC, OUC, OLP)
- /bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave (OLC, OUC, OUP)
- /bob2charlie+link (OUP, OLP)/bob2charlie+link-sub-bob2dave+link (OLC, OUC, OUP, OLP)
- /link (OLP)
- /link (OLP)/link-sub (OLC)
- /link (OLP)/link-sub+link (OLC, OLP)
- /link (OLP)/link-sub-bob2charlie (OLC, OUP)
- /link (OLP)/link-sub-bob2charlie+link (OLC, OUP, OLP)

### Kinds summary ###
- IUC
- IUC, OLC
- IUC, OLC, OLP
- IUC, OLC, OUC
- IUC, OLC, OUC, OLP
- IUC, OLC, OUC, OUP
- IUC, OLC, OUC, OUP, OLP
- IUC, OLC, OUP
- IUC, OLC, OUP, OLP
- IUC, OLP
- IUC, OUC
- IUC, OUC, OLP
- IUC, OUC, OUP
- IUC, OUC, OUP, OLP
- IUC, OUP
- IUC, OUP, OLP
- IUP
- IUP, OLP
- IUP, OUP
- IUP, OUP, OLP
- OLC
- OLC, OLP
- OLC, OUC
- OLC, OUC, OLP
- OLC, OUC, OUP
- OLC, OUC, OUP, OLP
- OLC, OUP
- OLC, OUP, OLP
- OLP
- OUC
- OUC, OLP
- OUC, OUP
- OUC, OUP, OLP
- OUP
- OUP, OLP

### Kinds legend ###
- IUP: incoming user share on current resource
- IUC: incoming user share exists on a parent resource
- OUP: outgoing user share on current resource
- OUC: outgoing user share exists on a parent resource
- OLP: outgoing link share on current resource
- OLC: outgoing link share exists on a parent resource```

@dpakach
Copy link
Contributor

dpakach commented Jan 21, 2020

I think using such script to setup all users and shares is good idea if we want to cover each and every possible combination but it is not essential IMO. Also those tests will be kind of inconsistent with the current acceptance tests suite. Maybe we can do just like in core (https://github.com/owncloud/core/pull/36572/files#diff-d5a7b47bf7d40f4780417db046827793R377) and try to cover all essential scenarios.

@PVince81 PVince81 self-assigned this Jan 21, 2020
@PVince81
Copy link
Contributor Author

@dpakach yeah, it is likely easier to reuse those tests first.

As this is blocking my PR #2060 I'll port the OC 10 tests over to Phoenix and adjust them accordingly, then add the share indicator check.

Once we touch further aspects like "collaborators list" and "share owner" for the same scenarios, we can simply add more "Then" steps to validate those.

@PVince81
Copy link
Contributor Author

I've managed to port most tests to #2877, at least for the share indicators for now.

I decided to not go with the "create user without skeleton" as I found it too cumbersome.

@PVince81
Copy link
Contributor Author

Fixed through #2877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PVince81 PVince81

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PVince81 @individual-it @dpakach