Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load assets of extension #2958

Open
Tracked by #7930
LukasHirt opened this issue Feb 2, 2020 · 4 comments
Open
Tracked by #7930

Load assets of extension #2958

LukasHirt opened this issue Feb 2, 2020 · 4 comments

Comments

@LukasHirt
Copy link
Collaborator

At the moment we load only the js bundle of extension. We need to be able to also load assets in case there are any (e. g. images)

@LukasHirt LukasHirt added this to the backlog milestone Feb 2, 2020
@LukasHirt
Copy link
Collaborator Author

Possible solution - use import.meta.url which returns URL where the module is located and access assets with that URL. This is not supported in Edge. Seems that polyfill already exists though https://www.npmjs.com/package/es-module-shims

So the next tasks are:

  • Test loading assets with this solution
  • Test polyfill for Edge
  • Document it so it's available for extensions developers.

@dschmidt
Copy link
Member

dschmidt commented Dec 7, 2022

Using import.meta.url might have become much easier as we're switching to native modules in #7952

@dschmidt dschmidt mentioned this issue Dec 7, 2022
30 tasks
@pascalwengerter
Copy link
Contributor

Is this issue still relevant given the progress that has been achieved in the overall project and extension system?

@dschmidt
Copy link
Member

dschmidt commented Sep 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants