Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files list indicators labels #3673

Closed
LukasHirt opened this issue Jun 25, 2020 · 9 comments
Closed

Files list indicators labels #3673

LukasHirt opened this issue Jun 25, 2020 · 9 comments

Comments

@LukasHirt
Copy link
Collaborator

Instead of labelling the whole indicators row with State, there should be a label for each indicator. This requires extending the extension point of indicators.

@PVince81
Copy link
Contributor

Yeah, so far I was very confused what the "State: -" meant.

@PVince81
Copy link
Contributor

"Shared with: -" in latest ocis-phoenix not looking better :-D

@kulmann
Copy link
Member

kulmann commented Jul 23, 2020

We did a little bit of visual prototyping in todays design initiative meeting. For that prototyping we added some wild guessed icons (partly they don't make sense), to see how it looks like in a crowded state, i.e. when there are more indicators.

Idea:

  • the wording should express a state (like Shared, Public, Tagged, etc)
  • label on the right of the indicator
  • try smaller font size for indicator row
  • hide labels on mobile

Screenshots:

Screenshot 2020-07-23 at 14 58 56
Screenshot 2020-07-23 at 14 59 44
Screenshot 2020-07-23 at 15 01 09
Screenshot 2020-07-23 at 15 01 26

Feedback appreciated. @micbar @LukasHirt

@LukasHirt
Copy link
Collaborator Author

I have quite mixed feelings about this. I like that the indicators have a label but seeing then multiple ones feels like too many items screaming for the attention.

@kulmann
Copy link
Member

kulmann commented Jul 24, 2020

We could try with even smaller font and grey text... grey text was also proposed yesterday. I just didn't have the time to continue on that.

@LukasHirt
Copy link
Collaborator Author

We could try with even smaller font and grey text...

Sounds like worth the try 🙂

@pascalwengerter
Copy link
Contributor

@tbsbdr could you update this to the current state of things eventually? :)

@tbsbdr
Copy link
Contributor

tbsbdr commented May 28, 2021

Current state of discussion

... and next steps:

  • purpose the sharing indicators proofed to be quite helpful for the users question "who has access?" at first glance
  • effective in the usability test the sharing indicators functionality was recognised correctly and gave safety to the users, as their (prior) sharing-action was reflected by the indicators (btw: fulfills "" visibility of system status https://www.nngroup.com/articles/visibility-system-status/)
  • similar purpose we have a similar component in the shared with others section - the "OcAvatarGroup" which shows even more detailed infos at first glace (number of shares and persons, link). I would love to see the "OcAvatarGroup" in the Files List, but this would slow down the system as it would eat lots of resources to collect all the sharing infos recursively -> practically not feasible

Problems with the current solution

  • conflict: condensed view as we also need a more condensed view in the future, the 2-lined Filename+Sharing indicator make it difficult to lower the whole row-height
  • small clickable area The indicators have only a clickable area of 24 x 24 px. ideally a clickable area is 44 px x 44 px (https://www.w3.org/WAI/WCAG21/Understanding/target-size.html)

Solution

long story short
--> move the sharing indicators into a separate column (as it was already done some time ago ;-) )
--> visually distinct the sharing indicators from the quickactions

compare:
image

@pascalwengerter
Copy link
Contributor

Superseded by more recent #5976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants