Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – Download a single file – Semantics and interactivity of interstitial file screen (when downloading) #4347

Closed
marcus-herrmann opened this issue Nov 18, 2020 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

marcus-herrmann commented Nov 18, 2020

Connected to Audit 1, see #4300
1.4 Download a single file, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

Clickable spans, no keyboard interactivity (2.1.1), thus no focus (2.4.7), overall wrong semantics for interactive controls (1.3.1)

Remediation

In case of an interstitial screen, e.g. .png file: Clickable spans should be buttons or links (depending on their function). Download control should be a with download attribute. All controls in this construct (see screenshot) must have at least accessible names, ideally visually dicernable text (Sidenode: Click events seem broken in Firefox 82).

Update Jan 22nd, 2021:

If the final download triggers are links, it should be clear from the link text that the link target is a file (WCAG: https://www.w3.org/TR/WCAG21/#link-purpose-in-context). Possible technique to remedy: Using aria-label: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA8 or aria-labelledby: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA7 Example2. Keep in mind that this is a string that possibly needs translation.

@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants