Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – Share a single file – Custom select "Rolle" not fully keyboard accessible #4407

Closed
marcus-herrmann opened this issue Dec 2, 2020 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

marcus-herrmann commented Dec 2, 2020

Connected to Audit 1, see #4300
1.5 Download a single file, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

The "Rolle:" widget inside the "add people" dialog (see screenshot) is not fully keyboard accessible. While it looks like a select/custom select/combobox it is actually something of a disclosure widget, and the DOM structure fits. You can open/trigger it with the space key, but the items inside the newly visible container ("Betrachter", "Editor", "Zusätzliche Rechte" are not reachable by keyboard.
Screenshot 2020-12-02 at 08 13 06

Remediation

Currently, .files-collaborators-roles-dropdown uses <li>s with a click event. Change this to <button>s instead. Alternatively, see #4790

@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants