Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – General Overview when logged in – Nav landmark disappearing #4766

Closed
marcus-herrmann opened this issue Feb 24, 2021 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

Connected to Audit 1, see #4300
1.2 General Overview when logged in, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

In the mobile state/mediaquery, the main navigation landmarks seems to get lost. The trigger for the mobile menu then lives directly in the header landmark.

Remediation

Keep the navigation landmark, and make sure that both triggering button and the navigation list itself is kept in it.

Sketch:

nav
  trigger-button
  ul

Related BITV test step: 2.4.1a

@marcus-herrmann marcus-herrmann changed the title Audit #1 – General Overview when logged in – Audit #1 – General Overview when logged in – Nav landmark disappearing Feb 24, 2021
@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants