Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit #1 – General Overview when logged in – Text inputs' error state can't be detected programmatically #4768

Closed
marcus-herrmann opened this issue Feb 24, 2021 · 1 comment

Comments

@marcus-herrmann
Copy link
Contributor

marcus-herrmann commented Feb 24, 2021

Connected to Audit 1, see #4300
1.2 General Overview when logged in, URL: https://ocis-a11y.owncloud.works/#/files/list

Issue

CleanShot 2021-02-24 at 13 21 44

When a (text) inputs data is validated to be in an error state (like depicted), the error message must be associated with the invalid input. Also, the input should be marked as invalid itself.

Remediation

Instead of:

<input aria-label="Ordnername" placeholder="Neuen Ordnernamen eingeben…" type="text" class="oc-text-input oc-text-input-danger"> 

<div class="oc-text-input-message"><!----> <span class="oc-text-input-danger">Neuer Ordner existiert bereits</span></div>

the Live DOM for inputs in an invalid state should be

<input aria-label="Ordnername" aria-invalid aria-describedby="errorMsg" placeholder="Neuen Ordnernamen eingeben…" type="text" class="oc-text-input oc-text-input-danger"> 

<div class="oc-text-input-message" id="errorMsg"><!----> <span class="oc-text-input-danger">Neuer Ordner existiert bereits</span></div>

Also, in case of an error, a live region (aria-live="assertive" or role=alert) should announce the error message.

Related BITV test step: 3.3.1a

@pascalwengerter
Copy link
Contributor

Closing this since #5018 is merged and we're waiting for feedback (and will open new tickets with the requested changes from the a11y audit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants