Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the same linting and prettier config like in ODS #5286

Closed
individual-it opened this issue Jun 17, 2021 · 4 comments
Closed

use the same linting and prettier config like in ODS #5286

individual-it opened this issue Jun 17, 2021 · 4 comments
Assignees

Comments

@individual-it
Copy link
Member

should we have the same configuration here as in ODS?
I noticed it because we are using single quotes here and double quotes in ODS

@kulmann @LukasHirt @pascalwengerter

@LukasHirt
Copy link
Collaborator

It's actually the other way round owncloud/owncloud-design-system#717

We wanted to create a repository with one config which will be then only pulled as a npm package into all projects where needed

@individual-it
Copy link
Member Author

individual-it commented Jun 18, 2021

closing in favour of owncloud/owncloud-design-system#717

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Jun 18, 2021

Let's keep it open since it applies to both repos (but the older issue in ODS gets more context and tackled first)

@pascalwengerter pascalwengerter self-assigned this Aug 31, 2021
@dschmidt
Copy link
Member

dschmidt commented Dec 9, 2022

We imported the ODS in #7940.

Naturally it shares the same config now.

@dschmidt dschmidt closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants