Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open files via public link in associated App (Collabora, OnlyOffice, Word etc.) #5776

Closed
tbsbdr opened this issue Sep 3, 2021 · 6 comments · Fixed by #5924
Closed

Open files via public link in associated App (Collabora, OnlyOffice, Word etc.) #5776

tbsbdr opened this issue Sep 3, 2021 · 6 comments · Fixed by #5924
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 3, 2021

Needed for Cern Stage 1 in Sept 2021

Userstory

As a user who receives a public link I want to have the option to open the file inside a "browser app" so that I don't have the need to install a local app to open the file.

Acceptance Criteria

  • show shared file(s) in files list
  • click on file executes standard action
  • context menu (via rightclick or 3-dots) offers alternative open-with ... apps
  • download is in the quickactions permanently visible as call-to-action

Context

In order to deliver the feature for cern until the end of September 2021, we need to focus on a solution that meets the minimum requirements. A more sophisticated solution (but not feasible in September) could be to open files directly in the associated app and provide "download" and "open with ..." from here. But such a solution would require a Full-screen view (see #5786).

Examples

Example oc10:

check it out: https://cloud.owncloud.com/index.php/s/VtY8JeMjKjtxj8F
image

Example Google Drive

check it out: https://docs.google.com/document/d/1WrkFjgioofvYe2uLsVdCW6zRvBb6qPp7/edit?usp=sharing&ouid=112080943748993282565&rtpof=true&sd=true

image

Example One Drive

check it out: https://1drv.ms/w/s!AmFv-ruebwpFkBX6BvqNLz3zRxAA?e=ky6BHQ

view mode:
image

edit mode:
image

Example Dropbox

check it out: https://www.dropbox.com/scl/fi/bco1nmvm9i8cp0ptujo77/Document.docx?dl=0&rlkey=pjwoqlyqdmxji4skh0tzoyrkk
image

Example Box.com

check it out: https://app.box.com/s/w0s97nf92wjrmj78oedlda73007c3tya

image

@exalate-issue-sync exalate-issue-sync bot added p3-medium Priority:p2-high Escalation, on top of current planning, release blocker and removed p3-medium labels Sep 3, 2021
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Sep 6, 2021

@labkode could you please check the acceptance criteria ^ to meet your "stage 1" requirements?

@exalate-issue-sync exalate-issue-sync bot added Type:Story User Story and removed Early-Adopter:CERN labels Sep 7, 2021
@exalate-issue-sync
Copy link

Tobias Baader commented: we need to wait until the app provider PR (#5712) is merged, then estimate this story.

@exalate-issue-sync
Copy link

Benedikt Kulmann commented: Dumping notes about the app provider here, due to lack of a good place for it:
concept: open editors in an iframe with only one web-extension (not one per editor like we had it before)
in context of web: app provider has 2 http endpoints
/app/list - gives you a list of mime types + app names
/open - throw fileId at it and specify an application (or leave empty). response is a URL + meta info if GET or form-POST is necessary for the iframe.

@labkode
Copy link

labkode commented Sep 8, 2021

@tbsbdr as of today OCIS does not offer the single view as we're used in OC10. OCIS currently shows a file listing independently if it was a public link targeting a folder or a file (attached screenshot).

(public link to a file)
Screenshot 2021-09-08 at 17 34 46

If I understood correctly what you propose is the same behaviour as will have when under "Your files".
To me is acceptable.

@diocas @elizavetaRa please comment.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Sep 8, 2021

If I understood correctly what you propose is the same behaviour as will have when under "Your files".

Yep, correct

@wkloucek
Copy link
Contributor

wkloucek commented Sep 9, 2021

@tbsbdr @micbar this is not possible without backend changes, I created a ticket for oCIS here: owncloud/ocis#2479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants