Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.3.0 #5872

Closed
25 tasks done
kulmann opened this issue Oct 4, 2021 · 9 comments
Closed
25 tasks done

Release 4.3.0 #5872

kulmann opened this issue Oct 4, 2021 · 9 comments

Comments

@kulmann
Copy link
Member

kulmann commented Oct 4, 2021

Release checklist

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Oct 6, 2021

Smoke test with ocis:
branch: v4.3.0-rc1

Case 1: admin share folder(with file) to marie:

Admin:
x. upload big file 30gb
x. upload folder with 1000 files.
v. Check pagination, count items per page
v upload folder(drag folder) "folder_to_share" with file.pdf
v share folder "folder_to_share" to marie with edit right
Marie:
v accept "folder_to_share"
rename "folder_to_share" (?admin don't see)
v upload new file "file.txt" to "folder_to_share" (admin see new file)
v rename file.pdf (use rigth click) (admin see that file changed name)
v try to move "folder_to_share" to "/" (400)
v copy "folder_to_share" to "/"
Admin:
v add new file.jpeg to "folder_to_share" (marie can see file without access)
v move file.pdf to "/" (marie can not see file.pdf)
v add new "file.txt" create new version. (marie can see new version)
Marie:
x can download both versions (!error 501)
v restore old version
Admin:
v change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)
Marie:
x decline folder (but folder exist in Shares - bug) - existing bug
Admin:
v delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Admin:
v upload file.jpeg
v share file.jpeg to marie with rigth viewer (use main menu. find marie by email marie@example.org)
Marie:
v accept file (marie can open/download/copy file but cannot delete/move/rename)
v copy file to "/"
v open file in Mediaviewer
v download file
Admin:
v change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)
Marie:
v rename file (admin don't see)
Admin:
v unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:
v create folder "for upload"
v add link with name "to_upload" with role "Uploader" with pass and expiration date
v open link (can only upload)
v upload file (admin can see new file)
v refresh page(page is empty)
v change share "for upload" from "Uploader" to "edit" (don't see expiration date)
x open old link (it work as upload)
v open new link (can open/download/copy/rename/move files)
v admin add new file to "for upload"
v refresh link (file exist)
v admin change pass (refresh link)

Case 4: admin create link to file

Admin:
v create file png
v add link with main menu
v open link(can open, download, see)
v change link, add pass
v refresh page (input pass)
v delete link
v refresh page (resourse not found)
v delete file
v restore
v delete
v Empty trash

Case 5: create new user:

Admin:
v create new account "tom"
Tom:
v go to account
v change language
Admin:
v block user (Login Error access denied)
v delete user (Logon failed)
v logout

Remarks:
Screenshot 2021-10-06 at 14 08 34
Screenshot 2021-10-06 at 14 10 45

@ScharfViktor
Copy link
Contributor

Smoke test standalone against oc10

  • ❌heavy_check_mark: as gunter - upload 2000 files to a folder- (only uploads 100 files)

  • ✔️ as gunter - share the folder as viewer

  • ✔️ as alice - share is already accepted.

  • :declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

  • ❌ as alice - copy 16 folders from share to home

    • no visible feedback that it's in progress
    • UI still weirdly usable, ended up in an active upload drop zone
  • ✔️ as gunter - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as gunter - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as gunter - share folder with alice again, but as editor

  • ✔️ as alice - rename file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as gunter - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ✔️ as alice download newest version of text file

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is not updated
  • ✔️ as alice - upload avatar in classic UI

    • login as dave, having a share with alice
    • shared with others page loads and shows avatars
  • ✔️ as alice, move a file into subfolder via drag and drop ()

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

@lookacat
Copy link
Contributor

lookacat commented Oct 6, 2021

Smoke test standalone against oc10

  • ❌ as gunter - upload 2000 files to a folder

    • browser gets slowed down alot
    • sometimes even doesnt load
  • ✔️ as gunter - share the folder as viewer

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected) but drag & drop doesnt work, which is acceptable

  • ❌ as alice - copy 16 folders from share to home
    move from shared folder makes browser lag alot sometimes freeze

  • ✔️ as gunter - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as gunter - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as gunter - share folder with alice again, but as editor

  • ✔️ as alice - rename file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as gunter - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ✔️ as alice download newest version of text file

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is updated
  • ✔️ as alice - upload avatar in classic UI

    • login as dave, having a share with alice
    • shared with others page loads and shows avatars
  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

@kulmann
Copy link
Member Author

kulmann commented Oct 6, 2021

Smoke test with ocis wopi deployment example and locally built web-4.3.0-rc1, using this branch extending the current wopi deployment example


archiver v2 feature

  • ✔️ as einstein - upload a folder test-folder with two files as content of the folder
    • ✔️right click contextmenu shows Download folder and downloads a download.tar which can be extracted properly on macOS
    • ✔️ All actions sidebar panel shows Download folder and downloads a download.tar which can be extracted properly on macOS
    • ✔️ the Download batch action for the selected test-folder downloads a download.tar which can be extracted properly on macOS
  • ✔️ as einstein - adding a file to the selection still shows the Download batch action
    • ✔️ batch action downloads a download.tar which can be extracted properly on macOS
  • ✔️ as einstein - removing the folder from the selection again still shows the Download batch action
    • ✔️ batch action does a single file download since only one file was selected

app provider feature

  • ✔️ as einstein - upload a file Lorem ipsum.docx
  • ✔️ right click contextmenu shows Open in Collabora + actually opens it in Collabora
  • ✔️ All actions sidebar panel shows Open in Collabora + actually opens it in Collabora
  • ✔️ using the default action on the file opens it in Collabora
  • ❌ Collabora shows all kinds of exceptions and doesn't render itself properly. Unusable. -> seems to be a collabora issue, not web related.
  • ✔️ Onlyoffice works properly
  • ✔️ as einstein - upload a file lorem-markdown.md
  • ✔️ CodiMD works properly

Remarks

  • context menu has a weirdly huge bottom padding
  • the order of Onlyoffice and Collabora in the actions and contextmenu seems to be random. feels weird.

@fschade
Copy link
Collaborator

fschade commented Oct 7, 2021

following smoke testing failures:

  1. upload 2000 files to a folder
  2. copy 16 folders from share to home
  3. (app provider) Collabora shows all kinds of exceptions and doesn't render itself properly. Unusable.
  4. (app provider) CodiMD is not available at all

i assume none of theme are release blocking, for 1. i already created a ticket.
#5882

thanks for testing

@kulmann
Copy link
Member Author

kulmann commented Oct 7, 2021

IMO (3) is a blocker for the release. We need to check if the error is caused in the frontend implementation. Will get back to you asap...

@kulmann
Copy link
Member Author

kulmann commented Oct 7, 2021

Ok, seems to be a collabora issue. Got Onlyoffice and CodiMD running. IMO release unblocked. Let's go ahead.

@kulmann
Copy link
Member Author

kulmann commented Oct 7, 2021

Please check this PR #5881 - would be nice to merge it into the release branch before we create the final tag.

@kulmann
Copy link
Member Author

kulmann commented Oct 7, 2021

Release done 🥳

@kulmann kulmann closed this as completed Oct 7, 2021
@kulmann kulmann unpinned this issue Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants