Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong iframe size for external apps #5960

Closed
wkloucek opened this issue Oct 29, 2021 · 4 comments · Fixed by #6003 or #6145
Closed

Wrong iframe size for external apps #5960

wkloucek opened this issue Oct 29, 2021 · 4 comments · Fixed by #6003 or #6145

Comments

@wkloucek
Copy link
Contributor

Bug

In the external apps view, there is always a scrollbar on the right and you don't see the full iframe. Looks like the iframe is too high.

Peek.2021-09-30.12-55.mp4

Originally posted by @wkloucek in #5805 (comment)

@wkloucek
Copy link
Contributor Author

The top bar is now gone and the iframe takes 100% percent high. Therefore the scrollbar is gone

image

Tested with oCIS 1.15.0-rc1 with Web 4.5.0

@wkloucek
Copy link
Contributor Author

@pascalwengerter @kulmann was removing the top bar intended?

@kulmann
Copy link
Member

kulmann commented Nov 22, 2021

Afaik not intended, no. But it's ok. With the new design we want to stay in the web context at any time. Removal of the top bar will be forbidden then.

@pascalwengerter
Copy link
Contributor

I just double-checked and we introduced this when making the app-provider available on public links from my understanding - usually you'd set hideHeadbar to false in the routes, but adding it below clashes between hideHeadbar and auth here

      hideHeadbar: false,
      auth: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants