Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting many files (n=500) using the web interface seems too slow #6060

Closed
nikslor opened this issue Nov 26, 2021 · 2 comments
Closed

Deleting many files (n=500) using the web interface seems too slow #6060

nikslor opened this issue Nov 26, 2021 · 2 comments

Comments

@nikslor
Copy link

nikslor commented Nov 26, 2021

Describe the bug

I stumbled upon this, when cloning my home dir to oCIS. After upload finished I had a large list of empty files in oCIS (may be related to owncloud/ocis#2609) and I wanted to get rid of them. I (manually) selected all empty files and deleted them through the web interface. It took minutes until the action was finished which I'd expect to happen faster. I think there is something fishy when deleting files - not sure if it's a bug, but it's reproducible slow (IMHO).
I sometimes also see a browser redirect to the root folder after deleting finished. This should IMHO not happen and may underline, that there's something not 100% right here. It most of the time happens, when I have 1000 files and delete 500 of those. (I'm happy to create a separate bug if you think it's worth it).

I think it's worth checking, it's not of high priority.

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a local folder with e.g. 1000 files: $ for i in $(seq 1 1000); do touch "$i.txt" && echo $i > "$i.txt" ; done
  2. Upload the folder to oCIS (e.g. using the web interface)
  3. Navigate into the folder and list e.g. 500 files
  4. Select all files
  5. Click/tap delete

Expected behavior

Deleting should not be much slower than uploading there should not be a redirect (to the root folder) after deleting.

Actual behavior

Deleting takes very long (IMHO), while uploading the 1000 files (using "upload folder" through the web interface) takes only ~50s, deleting 500 files takes around 12min. The HTTP DELETE requests as such are fired within seconds and I also see those request in the log on the server side immediately; it's unclear to me if the actual action takes so long or it's just the web interface not being updated correctly.

Setup

I use oCIS 1.15.0 on Linux x64 with a POSIX FS as backend and local users (not OICD, LDAP, ..), I start oCIS like this:

OCIS_BASE_DATA_PATH=/var/lib/ocis ACCOUNTS_DEMO_USERS_AND_GROUPS=false PROXY_HTTP_ADDR=0.0.0.0:443 OCIS_URL=https://storage.0x17.ch PROXY_TRANSPORT_TLS_KEY=./certs/fullchain.pem PROXY_TRANSPORT_TLS_CERT=./certs/cert.pem PROXY_ENABLE_BASIC_AUTH=true ./ocis server

As web browser I use Firefox 94 and Chrome 94 - both show +/- the same behavior.

Please let me know if you need more information, happy to provide them.

@pascalwengerter pascalwengerter transferred this issue from owncloud/ocis Nov 26, 2021
@pascalwengerter
Copy link
Contributor

Thanks for pointing this one out, I moved it to the web issue tracker since I'm fairly confident it's a frontend topic

@JammingBen
Copy link
Contributor

Has been fixed via #7357. The future holds an even better approach with async delete, but for now it does the job in a reasonable time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants