Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL - path | resourceId fallback #6247

Closed
exalate-issue-sync bot opened this issue Jan 13, 2022 · 2 comments · Fixed by #7725
Closed

URL - path | resourceId fallback #6247

exalate-issue-sync bot opened this issue Jan 13, 2022 · 2 comments · Fixed by #7725
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Story User Story

Comments

@exalate-issue-sync
Copy link

Description

User Stories

  • As a user who keeps bookmarks in the browser, I'd like to bookmark the files I often work with, so that I can access them quickly. I want the bookmarks to still work, even when I change the folder name or move a folder to another location.

  • As a user I would like to be able to copy the URL and give it to a colleague, so that it's easier to collaborate quickly (side note: requires respective permissions to the resource e.g. via a group share or similar, and the resource id in the URL).

Value

  • The URL can be bookmarked
  • The bookmarked URLs remain stable even if the path changes

Acceptance Criteria

  • resource ids have the format base64(<storage_id>:<file_id>)
  • resource loading:
    • path takes precedence over the id, but requires validation if both are given. workflow:
    • 1: try to load resources by path
    • 2: if loading by path fails:
      • if id present: load by id + rewrites (not redirect because the operation shouldnt be in browser history) to URL with correct path and id
      • if id absent: show "resource not found" page
    • 3: if loading by path succeeds:
      • if id present: must match with propfind response, otherwise "resource not found" page
      • if id absent: render result and rewrites (not redirect because the operation shouldnt be in browser history) to URL with correct path and id
  • whether or not the URL contains an id as query param must be configurable (client side config, since it's not relevant for other client platforms), if the feature is disable none of above points take place

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@kulmann
Copy link
Contributor

kulmann commented Apr 13, 2022

There's this reva edge PR for bringing support for a propfind to the /dav/meta/<resourceid> endpoint in order to get the relative path: cs3org/reva#2741 - and that's a prerequisite for this ticket.

@kulmann
Copy link
Contributor

kulmann commented Sep 30, 2022

Currently blocked by owncloud/ocis#4727

@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Story User Story
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants