-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File uploads with chunking and resumable #67
Comments
We need to check if this plays well together with offline capabilities ...... |
Depends if we expect uploading to be an offline capability... |
Estimate:
total: 8-10md |
From what I see, resumable JS is using POST with multipart, which is not desired and not compatible with Webdav. We'd need to rewrite parts of resumable JS to talk our Webdav chunking protocol. |
seems there is a way to set the method to be "PUT". Also see this old "OC bulk upload" app which was based on resumable.js: https://github.com/fmkaiser/bulkupload |
Is this still a thing to discuss since there allready is a working upload method by now? |
@scramb How does uploads work now? Chunked? Do they resume after being offline? Otherwise we should keep it open for a future sprint… |
yes - we need to keep this open. |
Might be interesting to look into TUS protocol for resumable, chunked uploads. Implementations exist in both Golang and Javascript. Saving this here for later. https://tus.io/implementations.html |
With the plan in mind to use the msgraph API. Please postpone this issue until WE are Set. |
We're going to look into the TUS protocol using https://github.com/tus/tus-js-client For prototyping, let's put the code into Phoenix directly and dynamically override the Later on we could decide to move the function to the SDK once it's ready. Thoughts: since we're going to pass in extra metadata like "mtime", we should pass those as part of the "options" argument and not as part of the headers, because the way of passing metadata with TUS is different than for the OC 10 approach. |
|
We should look into using http://www.resumablejs.com/ for Phoenix.
Don't pick up the old upload code from core as it uses jquery.fileupload and needs to much hacking around to make it work with our chunking.
The text was updated successfully, but these errors were encountered: