Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long breadcrumb: truncate and add drop menu #6731

Closed
tbsbdr opened this issue Apr 4, 2022 · 12 comments · Fixed by #8984
Closed

Long breadcrumb: truncate and add drop menu #6731

tbsbdr opened this issue Apr 4, 2022 · 12 comments · Fixed by #8984
Assignees
Labels
Type:Bug Something isn't working Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Apr 4, 2022

Steps to reproduce

  1. login on web.owncloud.com, switch to new design
  2. create many folders and open them until the breadcrumb line-breaks

Expected behaviour

Breadcrumb should not line-break

Actual behaviour

Breadcrumb Line-breaks:
image

Proposal

  • truncate the breadcrumb with ... on the left, so that it does not line-break
  • click on ... opens a drop menu with only the remaining i.e. truncated (hidden) folders.
  • click on item navigates to the respective folder
  • root elements are not truncated, i.e. Personal, Spaces > Mars stays visible, truncation starts after that

Scribble:
image

@fschade
Copy link
Collaborator

fschade commented Apr 11, 2022

maybe the easiest solution

<div id="parent">
  <ul id="child" class="breadcrumb">...</ul>
</div>

#parent -> overflow-x: hidden
#child -> whitespace: nowrap
#child.li -> max-width: xrem; ... text-overflow: ellipsis;

window.onResize: #child.outerWitdh >= #parent.outerWitdh => child.li -> pop

@lookacat
Copy link
Contributor

Would propose doing it like flo said, I tried to find another solution but I'm not sure if the three dots menu is possible that easy :/

@lookacat lookacat self-assigned this Apr 24, 2022
@kulmann
Copy link
Member

kulmann commented Apr 25, 2022

Would propose doing it like flo said, I tried to find another solution but I'm not sure if the three dots menu is possible that easy :/

You could have a look at what the classic ui in oc10 does. That has the truncation like we want to have it (not the three dots menu though, but that could be solved in a separate PR). The click behaviour on the truncated part feels non-deterministic in oc10 classic ui, so I'd propose to just not react at all on a click on the ... in the first iteration.

@hurradieweltgehtunter
Copy link
Contributor

depending issue: creating a new folder in a deep nested folder with line-breaking breadcrumb results in this:

grafik

Gets resolved on changeing the windows width or reloading the page.

@elizavetaRa
Copy link
Member

We are facing the problem (also tested on ocis.ocis-traefik.latest.owncloud.works) that the line break is not happening for long breadcrumbs and as a result the breadcrumb keeps the width for the web-app-files. It makes the sidebar unusable.
227143572-695c043d-96ae-4e0d-a0cd-ce5384308330

@lookacat
Copy link
Contributor

lookacat commented May 4, 2023

We've would go for a solution similar to that of dropbox. If the breadcrumbs total length is greater than the available size, we remove items from the front but leaving personal and showing a dropdown for the hidden items. (e.g. Personal > ... > someFolder > subFolder)

Very small technical PoC (without the dropdown yet)
236193597-a0a198c5-891c-4709-8c21-41289ef01080.webm

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented May 4, 2023

Very small technical PoC (without the dropdown yet) 236193597-a0a198c5-891c-4709-8c21-41289ef01080.webm

yes! i like that

@lookacat
Copy link
Contributor

We've committed to don't build an dropdown for the ... item because its confusing, the ... will be clickable and direct you to the last hidden folder.
We also want to address smaller screen sizes in the future because even with this change on some viewports there is not enough space and it will result in horizontal scrolling which is a nogo.

@hurradieweltgehtunter
Copy link
Contributor

We've committed to don't build an dropdown for the ... item because its confusing, the ... will be clickable and direct you to the last hidden folder. We also want to address smaller screen sizes in the future because even with this change on some viewports there is not enough space and it will result in horizontal scrolling which is a nogo.

Please don't.
The ... solution can be done including supporting small screens, that's not the point.
Check google drive or onedrive. They all go with the … solution, so it has to work. Going back to the last folder is confusing since … does not clearly state this action. … stands for "more context" or "more options".
Imagine you are in a deeply nested folder and want to navigate x folders back.
Dropdown: Just select the folder
goBackSolution: Click, wait till view loaded, click, wait till view loaded, click ...

@kulmann
Copy link
Member

kulmann commented May 17, 2023

We've committed to don't build an dropdown for the ... item because its confusing, the ... will be clickable and direct you to the last hidden folder. We also want to address smaller screen sizes in the future because even with this change on some viewports there is not enough space and it will result in horizontal scrolling which is a nogo.

Please don't. The ... solution can be done including supporting small screens, that's not the point. Check google drive or onedrive. They all go with the … solution, so it has to work. Going back to the last folder is confusing since … does not clearly state this action. … stands for "more context" or "more options". Imagine you are in a deeply nested folder and want to navigate x folders back. Dropdown: Just select the folder goBackSolution: Click, wait till view loaded, click, wait till view loaded, click ...

... or go back to the top and then down again :-P

The mobile viewports don't use this breadcrumb design anyway, so we're talking about ipad size or larger.
In my opinion a good first iteration to interpret click on ... like @lookacat described, check user feedback and then build a dropdown only if really needed. The dropdown has its own quirks. E.g. it's always confusing if the hierarchy in the dropdown has to be interpreted from top to bottom or from bottom to top.

Heard your voice as a first indicator that ... without dropdown might not be sufficient as a solution. But let's please see this in action and then iterate further. Dropdown would be a pure addon behaviour anyway.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 13, 2023

relates to 7abee7a

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 28, 2023

Question to @elizavetaRa
does the current implementation suit your needs regarding:

you can check the current implementation here: (admin:admin)
https://ocis.ocis-web.latest.owncloud.works/

(admin:admin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working Type:Story User Story
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants