Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick-rename button not visible on keyboard-focus #6755

Closed
kulmann opened this issue Apr 7, 2022 · 5 comments · Fixed by #6817
Closed

Quick-rename button not visible on keyboard-focus #6755

kulmann opened this issue Apr 7, 2022 · 5 comments · Fixed by #6817
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Apr 7, 2022

Steps to reproduce

  1. have a file list
  2. cycle through interactive elements with the TAB key on your keyboard
  3. reach a file name
  4. hit TAB once more

Expected behaviour

The quick rename button that usually appears on mouse hover to the right of the file name also appears on keyboard focus.

Actual behaviour

The quick rename button has keyboard focus (and can actually be interacted with) but stays visually hidden.

@kulmann kulmann added the Type:Bug Something isn't working label Apr 7, 2022
@kulmann kulmann added the Priority:p3-medium Normal priority label Apr 7, 2022
@kulmann
Copy link
Member Author

kulmann commented Apr 8, 2022

Thinking more about this, I think the rename button should be visible for the row that has the keyboard focus on any of its interactive elements. E.g. checkbox of row 3 focused -> already make the rename button in row 3 visible.

@kulmann
Copy link
Member Author

kulmann commented Apr 8, 2022

Screenshot 2022-04-08 at 10 51 52

Having the quick rename button visible all the time for all rows would look this this ^

@AlexAndBear AlexAndBear self-assigned this Apr 25, 2022
@AlexAndBear
Copy link
Contributor

@kulmann having it visible all the time would be more accessible, IHMO otherwise it is more of a hidden feature to most users
What do you think?
FYI @tbsbdr

@kulmann
Copy link
Member Author

kulmann commented Apr 25, 2022

@kulmann having it visible all the time would be more accessible, IHMO otherwise it is more of a hidden feature to most users
What do you think?
FYI @tbsbdr

could you try with the muted text color as default and then use the regular text color (higher contrast) on hover? my screenshot above is too heavy IMO

@AlexAndBear
Copy link
Contributor

@kulmann Sure, please have a look:
#6817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants