Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications look different from the design + are blocking #7082

Closed
tbsbdr opened this issue Jun 1, 2022 · 3 comments · Fixed by #7139
Closed

Notifications look different from the design + are blocking #7082

tbsbdr opened this issue Jun 1, 2022 · 3 comments · Fixed by #7139
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 1, 2022

Steps to reproduce

  1. Login to https://ocis.ocis-web.latest.owncloud.works
  2. create a new folder
  3. Notifications look different from the design and blocks me from entering a search term

Expected behaviour

In context
Notification

Outlines
image

Shadow and vertically aligned first row (along red line)
image

Actual behaviour

  • Notifications look different from the design + are blocking
@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jun 1, 2022
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 1, 2022

@pascalwengerter @lookacat needs assessment on how notifications can stay accessible regarding focusmanagement I guess.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 17, 2022

Examples on where might users expect notifications?
screenie_Brave Browser_2022-06-17_at_13-27-22@2x

image

screenie_Brave Browser_2022-06-17_at_13-26-36@2x

screenie_Brave Browser_2022-06-17_at_13-25-58@2x

screenie_Brave Browser_2022-06-17_at_13-24-57@2x

image

image

@pascalwengerter
Copy link
Contributor

Discussed with @tbsbdr that this ticket will re-scoped to "redesign & reposition" - adding animations, a close button and a potential further button/link as part of the message require more concepting & a11y considerations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants