Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error when pasting with empty clipboard #7146

Closed
pascalwengerter opened this issue Jun 20, 2022 · 2 comments · Fixed by #7214
Closed

Console error when pasting with empty clipboard #7146

pascalwengerter opened this issue Jun 20, 2022 · 2 comments · Fixed by #7214
Assignees
Labels
feature:files Topic:good-first-issue beginner friendly task Type:Bug Something isn't working

Comments

@pascalwengerter
Copy link
Contributor

Not a very visual error, yet worth preventing I suppose

Steps to reproduce

  1. Press Ctrl + v on a freshly reloaded page (e.g. personal space root)
  2. Nothing happens in the UI, TypeError: u is undefined error in pasteSelectedFiles on browser console

Expected behaviour

No console error, maybe display a message to the user about not being able to paste zero files? @tbsbdr could be nice, don't know of an app/OS that does this though

@pascalwengerter pascalwengerter added Type:Bug Something isn't working feature:files labels Jun 20, 2022
@pascalwengerter pascalwengerter added the Topic:good-first-issue beginner friendly task label Jun 20, 2022
@pascalwengerter
Copy link
Contributor Author

Worth mentioning that I can't reproduce this with Ctrl + x on an empty selection

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 23, 2022

display a message to the user about not being able to paste zero files

I would recommend to stay silent in the ui because users are likely to not expect a message at that point, because - as you say - they are not used to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:files Topic:good-first-issue beginner friendly task Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants