Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting a folder into itself creates some recursive madness #7148

Closed
pascalwengerter opened this issue Jun 20, 2022 · 2 comments · Fixed by #7151
Closed

Pasting a folder into itself creates some recursive madness #7148

pascalwengerter opened this issue Jun 20, 2022 · 2 comments · Fixed by #7151
Labels
feature:files Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Jun 20, 2022

Update: Spotted inside (project) spaces, perhaps also happening on oC10/personal space/share jail

Steps to reproduce

  1. Create a folder Foo with a subfolder Bar
  2. Go to Foo's parent folder, select Foo and copy/cut using keyboard shortcuts
  3. Navigate into Bar and paste Foo there. UI freezes. On subsequent paste actions, you get a conflict dialogue. Skipping it or reloading the page leads to a recursive list of Foo => Bar => Foo => Bar => ...

Expected behaviour

Foo and the resources it contains should get copied into Bar just once

Actual behaviour

Chaos (if one of the folders contains files there's also conflict dialogues for those which are not very well explained to the user)

@pascalwengerter pascalwengerter added Type:Bug Something isn't working feature:files Priority:p1-urgent Consider a hotfix release with only that fix labels Jun 20, 2022
@kulmann
Copy link
Member

kulmann commented Jun 20, 2022

Actually I'd expect something like You can’t paste the selected files at this location because you can’t paste an item into itself., no?

@pascalwengerter
Copy link
Contributor Author

Actually I'd expect something like You can’t paste the selected files at this location because you can’t paste an item into itself., no?

True, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:files Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants