Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project space have public links from the personal space #7268

Closed
ScharfViktor opened this issue Jul 12, 2022 · 6 comments · Fixed by #7294
Closed

Project space have public links from the personal space #7268

ScharfViktor opened this issue Jul 12, 2022 · 6 comments · Fixed by #7294
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ownCloud Web UI 5.7.0-rc.5:

Prerequisite:

  • create a folder with the file in your personal space
  • create a public link to the folder

Steps:

  • create new project space
  • go to the members

Actual: here we have a public link from personal space

Screen.Recording.2022-07-12.at.14.28.13.mov
@ScharfViktor ScharfViktor added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jul 12, 2022
@pascalwengerter
Copy link
Contributor

Can confirm, this is critical and needs investigation

@ScharfViktor ScharfViktor mentioned this issue Jul 12, 2022
36 tasks
@ScharfViktor ScharfViktor added the Priority:p2-high Escalation, on top of current planning, release blocker label Jul 15, 2022
@pascalwengerter
Copy link
Contributor

Can confirm, this is critical and needs investigation

When investigating, I have started the recently released beta.4

  • with the embedded web it brings and the problem does not arise
  • with the current web master (aka close to v5.7.0-rc.5) and the problem shows up
    which leads me to the conclusion that this is a frontend issue, most likely related to either the auth (or resharing?) refactorings

@pascalwengerter
Copy link
Contributor

Can confirm, this is critical and needs investigation

When investigating, I have started the recently released beta.4

* with the embedded `web` it brings and the problem does not arise

* with the current `web` master (aka close to `v5.7.0-rc.5`) and the problem shows up
  which leads me to the conclusion that this is a frontend issue, most likely related to either the auth (or resharing?) refactorings

Checked out 434a622 (merge commit of the auth PR) and the issue is present there (resharing was merged a day later IIRC so it shouldn't be the culprint)

@pascalwengerter
Copy link
Contributor

Can confirm, this is critical and needs investigation

When investigating, I have started the recently released beta.4

* with the embedded `web` it brings and the problem does not arise

* with the current `web` master (aka close to `v5.7.0-rc.5`) and the problem shows up
  which leads me to the conclusion that this is a frontend issue, most likely related to either the auth (or resharing?) refactorings

Checked out 434a622 (merge commit of the auth PR) and the issue is present there (resharing was merged a day later IIRC so it shouldn't be the culprint)

Also checked 94b0538 which was right before the auth PR got merged and it's fine there, so I guess #7072 caused the regression

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Jul 15, 2022

Can confirm, this is critical and needs investigation

When investigating, I have started the recently released beta.4

* with the embedded `web` it brings and the problem does not arise

* with the current `web` master (aka close to `v5.7.0-rc.5`) and the problem shows up
  which leads me to the conclusion that this is a frontend issue, most likely related to either the auth (or resharing?) refactorings

Checked out 434a622 (merge commit of the auth PR) and the issue is present there (resharing was merged a day later IIRC so it shouldn't be the culprint)

Also checked 94b0538 which was right before the auth PR got merged and it's fine there, so I guess #7072 caused the regression

Looks like currentFolder.path is an empty string in

which leads to all shares being fetched upon navigating into a project space?

@kulmann kulmann removed the Priority:p3-medium Normal priority label Jul 19, 2022
@kulmann kulmann self-assigned this Jul 19, 2022
@kulmann
Copy link
Member

kulmann commented Jul 19, 2022

storageId: this.highlightedFile.fileId,
tries to use the fileId property of a resource for loading shares, but that field is empty for spaces, see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants