Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiles view] Resize tiles #8368

Closed
4 tasks done
pascalwengerter opened this issue Feb 4, 2023 · 3 comments · Fixed by #8483
Closed
4 tasks done

[Tiles view] Resize tiles #8368

pascalwengerter opened this issue Feb 4, 2023 · 3 comments · Fixed by #8483
Assignees

Comments

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Feb 4, 2023

Expected behaviour

Tiles can be resized using a slider component (HTML range input, potentially to be added to the ODS).
Details for tile sizing have been sketched out in #6126 and #7991 . Independently of the current tile size on bigger viewports, #8367 should be respected on mobile from my understanding

Open tasks:

  • Implement slider
  • Resize the default file icon with the tile size
  • Fix view when using bigger tile-sizes and having a small screen and/or opening the sidebar. Content may float out of the right screen currently.
  • Only show tile size slide when tile size is supported

Bonus: Use e.g. https://vueuse.org/core/useresizeobserver/#useresizeobserver to load & update currently viewed tiles with bigger thumbnails upon resizing on certain thresholds (only when enlarging tiles, keeping the bigger size of already loaded tiles when decreasing the size should be fine).

@ChrisEdS
Copy link

Great stuff! I know this is work in progress but, for the record, I saw the following on main branch:

  1. Set the tiles view slider to the second position
  2. Open a document in OnlyOffice
  3. Switch back to files view inside the new tab

Expected

The tiles view still has the size I set before

Current

The slider has still the second position but the tiles view is set back to the not enlarged state

image

@ChrisEdS
Copy link

I don't know if it's in scope but as a power user I would like to be able to select images (tick the boxes) with the keyboard.

@kulmann
Copy link
Member

kulmann commented Feb 14, 2023

I don't know if it's in scope but as a power user I would like to be able to select images (tick the boxes) with the keyboard.

Not really in scope at the moment, but wanted behaviour. I created an issue for it #8429

@JammingBen JammingBen self-assigned this Feb 21, 2023
@JammingBen JammingBen mentioned this issue Feb 21, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants