Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] immediately jump into editing (single file public link) #9045

Closed
exalate-issue-sync bot opened this issue May 15, 2023 · 2 comments · Fixed by #9046
Closed

[web] immediately jump into editing (single file public link) #9045

exalate-issue-sync bot opened this issue May 15, 2023 · 2 comments · Fixed by #9046

Comments

@exalate-issue-sync
Copy link

Description

User Stories

  • As a user creating and sharing a single file public link I want the link receiver to jump into editing/viewing the file content, so that they can collaborate without detours.

  • As a person receiving a single file public link I don't want to deal with the mental load of file metadata and deciding which editor to choose so that I can focus on the content that was shared with me.

Value

Access to content of a single file is as quick and easy to understand as possible.

Acceptance Criteria

Context: single file public link opens in a ResourceDetails view, which shows a preview image / file type icon and all available file actions (e.g. open in Preview app, Download, ...).

  • Open single file public link in default editor / application if one is available.
    • resolvePublicLink / resolvePrivateLink page adds new query param (e.g. openWithDefaultApp), ResourceDetails view redirect to default action if openWithDefaultApp is set and a default action is available.
  • Stay on the ResourceDetails view if no editors are available
  • Admin should be able to disable the public link resolving to the default editor (by default we want the routing to take place) via config.json options.
  • Add config option as environment variable to ocis (frontend service)

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer. Minimum: check that routing is triggered.
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 13, 2023

should superseed: 1c4c93d

Demo

screenshot_001222.mp4

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 15, 2023

relates to b29df64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants