[web] Open in web or app banner #9139

exalate-issue-sync · 2023-05-31T10:17:29Z

Description

User Stories

As a mobile user who receives an ocis link ex. via messenger, I want to decide if the link should get opened in my mobile app or browser so that I have control over my tooling.

Value

Acceptance Criteria

If the user opens an ocis link on an ios/ipadOS or android device, the user should see in the mobile browser
- Button: [Open in App]
- option to dismiss the banner "X"
- banner gets shown every time the user clicks on a shared ocis link
  [~tbaader]add scribbles
new config option in theme.json mobile App scheme (owncloud://...) default: "owncloud"
Click on [Open in App] opens the file in the App
Note: If the user has no access to the corresponding resource, a errormessage is shown by the corresponding client

Implementation Note:

ipadOS user agent gets announced as "MacOS"
mabye use library to detect ipads as they get annonced as "MacOS" (ex. lib "Mobile Detect")

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

Functional requirements
[ ] functionality described in the user story works
[ ] acceptance criteria are fulfilled
Quality
[ ] code review happened
[ ] CI is green
[ ] critical code received unit tests by the developer
[ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
Non-functional requirements
[ ] no sonar cloud issues

The text was updated successfully, but these errors were encountered:

michaelstingl · 2023-05-31T10:23:16Z

michaelstingl · 2023-06-02T13:18:23Z

Android Examples from other Services


Google Meet	GoTo Meeting	GoTo Meeting (installed)	Microsoft Teams	Zoom

Elements / features used

Download link
Link to open Android app
Fake "Smart App Banner" (no reliable native Android feature, but tools like smartbanner.js could help)
Redirect to open in App right away

Google Meet link redirects to Play Store 🤔

michaelstingl · 2023-06-02T13:25:14Z

Fake "Smart App Banner" (no reliable native Android feature, but tools like smartbanner.js could help)

More information:

michaelstingl · 2023-06-02T13:34:19Z

Link to open Android app

More information:

https://developer.android.com/training/app-links

michaelstingl · 2023-06-02T14:27:41Z

iOS Examples from other Services


Google Meet	GoTo Meeting	GoTo Meeting (installed)	Microsoft Teams (installed)	Zoom (installed)

Elements / features used

Download link
Link to open iOS app
iOS Safari native Smart App Banner
"Universal Links banner" (if you have enabled Universal Links for your domain and the app is already installed on the device, Safari will automatically show a smaller version of the app banner.)
Copies link to clipboard feature/hack, so the iOS apps can retrieve it from there

michaelstingl · 2023-06-19T16:04:52Z

Users will receive a link like this on their mobile device (mail, messenger etc):

https://ocis.ocis-traefik.daily.owncloud.works/s/xbRJjSSUUrlmait

Link opens Web in mobile browser, and performs a request against the unauthenticated tokeninfo endpoint:

/ocs/v1.php/apps/files_sharing/api/v1/tokeninfo/unprotected/xbRJjSSUUrlmait

% curl -s https://ocis.ocis-traefik.daily.owncloud.works/ocs/v1.php/apps/files_sharing/api/v1/tokeninfo/unprotected/xbRJjSSUUrlmait | xmllint --format -
<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>100</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <token>xbRJjSSUUrlmait</token>
    <link_url>/s/xbRJjSSUUrlmait</link_url>
    <password_protected>false</password_protected>
    <alias_link>false</alias_link>
    <id>0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51!d485c939-0141-456b-8a97-5bfa9497ddff</id>
    <storage_id>0f1c87f7-92e5-4549-8197-c7ece53e2e87</storage_id>
    <space_id>4c510ada-c86b-4815-8820-42cdf82c3d51</space_id>
    <opaque_id>d485c939-0141-456b-8a97-5bfa9497ddff</opaque_id>
    <path/>
    <space_path/>
    <space_alias/>
    <space_url/>
    <space_type/>
  </data>
</ocs>

From the <id>0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51!d485c939-0141-456b-8a97-5bfa9497ddff</id>, web can generate a link, that gets displayed as the [Open in App] button:

owncloud://ocis.ocis-traefik.daily.owncloud.works/f/0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51!d485c939-0141-456b-8a97-5bfa9497ddff

This link will then open the mobile app.

michaelstingl · 2023-06-19T16:10:46Z

Link opens Web in mobile browser, and performs a request against the unauthenticated tokeninfo endpoint:

/ocs/v1.php/apps/files_sharing/api/v1/tokeninfo/unprotected/xbRJjSSUUrlmait

@micbar @tbsbdr @kulmann seems this doesn't work with password protected links:

% curl -s https://ocis.ocis-traefik.daily.owncloud.works/ocs/v1.php/apps/files_sharing/api/v1/tokeninfo/unprotected/qVroPUsyqNgsKAi  | xmllint --format -
<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>ok</status>
    <statuscode>100</statuscode>
    <message>OK</message>
  </meta>
  <data>
    <token>qVroPUsyqNgsKAi</token>
    <link_url>/s/qVroPUsyqNgsKAi</link_url>
    <password_protected>true</password_protected>
    <alias_link>false</alias_link>
    <id/>
    <storage_id/>
    <space_id/>
    <opaque_id/>
    <path/>
    <space_path/>
    <space_alias/>
    <space_url/>
    <space_type/>
  </data>
</ocs>

There it only works when you PROPFIND with basic-auth (link password):

% curl -s 'https://ocis.ocis-traefik.daily.owncloud.works/remote.php/dav/public-files/qVroPUsyqNgsKAi' \
-X 'PROPFIND' \
-H 'Authorization: Basic cHVibGljOjEyMzQ1Ng==' \
--data-binary $'<?xml version="1.0"?>
<d:propfind  xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:prop>
    <oc:id />
    <oc:privatelink />
  </d:prop>
  </d:propfind>' | xmllint --format -
<?xml version="1.0"?>
<d:multistatus xmlns:s="http://sabredav.org/ns" xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:response>
    <d:href>/remote.php/dav/public-files/qVroPUsyqNgsKAi/</d:href>
    <d:propstat>
      <d:prop>
        <oc:id/>
        <oc:privatelink/>
      </d:prop>
      <d:status>HTTP/1.1 404 Not Found</d:status>
    </d:propstat>
  </d:response>
  <d:response>
    <d:href>/remote.php/dav/public-files/qVroPUsyqNgsKAi/Photos-001.zip</d:href>
    <d:propstat>
      <d:prop>
        <oc:id>0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51!d485c939-0141-456b-8a97-5bfa9497ddff</oc:id>
        <oc:privatelink>https://ocis.ocis-traefik.daily.owncloud.works/f/0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51%21d485c939-0141-456b-8a97-5bfa9497ddff</oc:privatelink>
      </d:prop>
      <d:status>HTTP/1.1 200 OK</d:status>
    </d:propstat>
  </d:response>
</d:multistatus>

It doesn't work with the credentials from the owner of the resource:

% curl -s 'https://ocis.ocis-traefik.daily.owncloud.works/remote.php/dav/public-files/qVroPUsyqNgsKAi' \
-X 'PROPFIND' \
-H 'Authorization: Bearer REDACTED' \
--data-binary $'<?xml version="1.0"?>
<d:propfind  xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns">
  <d:prop>
    <oc:id />
    <oc:privatelink />
  </d:prop>
  </d:propfind>' | xmllint --format -
<?xml version="1.0" encoding="UTF-8"?>
<d:error xmlns:d="DAV" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotAuthenticated</s:exception>
  <s:message>No 'Authorization: Basic' header found</s:message>
</d:error>

michaelstingl · 2023-06-19T17:21:32Z

The owner of a resource could query /ocs/v1.php/apps/files_sharing/api/v1/shares and filter the result for the token>qVroPUsyqNgsKAi</token>:

% curl -s 'https://ocis.ocis-traefik.daily.owncloud.works/ocs/v1.php/apps/files_sharing/api/v1/shares?include_tags=false&share_types=3' \
-H 'Authorization: Bearer REDACTED' | xmllint --format - | grep -E 'token|space_id|item_source'
      <token>qVroPUsyqNgsKAi</token>
      <space_id>0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51!4c510ada-c86b-4815-8820-42cdf82c3d51</space_id>
      <item_source>0f1c87f7-92e5-4549-8197-c7ece53e2e87$4c510ada-c86b-4815-8820-42cdf82c3d51!d485c939-0141-456b-8a97-5bfa9497ddff</item_source>

Then construct the link with <space_id> and <item_source>…

michaelstingl · 2023-10-25T18:16:43Z

Implementation Note:

ipadOS user agent gets announced as "MacOS"

mabye use library to detect ipads as they get annonced as "MacOS" (ex. lib "Mobile Detect")

Doesn't work reliable:

[Log]  ownCloud Web UI 8.0.0-alpha.4  (index.html-3c2aed60.mjs, line 1)
[Log]  Infinite Scale 4.0.0+337dca17e Community  (index.html-3c2aed60.mjs, line 1)

michaelstingl · 2023-10-25T18:23:03Z

Elements / features used

Download link

How can I go to the install page, im case the app isn't installed yet?

[Log]  ownCloud Web UI 8.0.0-alpha.4  (index.html-3c2aed60.mjs, line 1)
[Log]  Infinite Scale 4.0.0+337dca17e Community  (index.html-3c2aed60.mjs, line 1)

michaelstingl · 2023-11-20T17:48:25Z

Config docs:

michaelstingl · 2023-11-20T17:49:40Z

FR for config option to disable:

[web] Disable App Banner #10015

exalate-issue-sync bot added p3-medium Type:Story User Story labels May 31, 2023

exalate-issue-sync bot changed the title ~~[ocis] Open in web or app~~ [web] Open in web or app May 31, 2023

exalate-issue-sync bot changed the title ~~[web] Open in web or app~~ [web] Open in web or app banner Aug 7, 2023

michaelstingl mentioned this issue Sep 5, 2023

[SPIKE] Deep Links 2.0 owncloud/android#4068

Closed

fschade mentioned this issue Sep 26, 2023

self-built app banner #9696

Merged

10 tasks

grimmoc closed this as completed in #9696 Sep 28, 2023

exalate-issue-sync bot added the koko label Oct 9, 2023

michaelstingl mentioned this issue Oct 25, 2023

Add documentation for app banner config #9836

Closed

michaelstingl reopened this Oct 25, 2023

kulmann mentioned this issue Nov 21, 2023

[web] Disable App Banner #10015

Closed

tbsbdr added the Web-only Issue without backend dependecies label Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] Open in web or app banner #9139

[web] Open in web or app banner #9139

exalate-issue-sync bot commented May 31, 2023 •

edited

Loading

michaelstingl commented May 31, 2023

michaelstingl commented Jun 2, 2023 •

edited

Loading

michaelstingl commented Jun 2, 2023 •

edited

Loading

michaelstingl commented Jun 2, 2023

michaelstingl commented Jun 2, 2023

michaelstingl commented Jun 19, 2023 •

edited

Loading

michaelstingl commented Jun 19, 2023 •

edited

Loading

michaelstingl commented Jun 19, 2023 •

edited

Loading

michaelstingl commented Oct 25, 2023

michaelstingl commented Oct 25, 2023

Elements / features used

michaelstingl commented Nov 20, 2023

michaelstingl commented Nov 20, 2023

[web] Open in web or app banner #9139

[web] Open in web or app banner #9139

Comments

exalate-issue-sync bot commented May 31, 2023 • edited Loading

Description

User Stories

Value

Acceptance Criteria

Definition of ready

Definition of done

michaelstingl commented May 31, 2023

michaelstingl commented Jun 2, 2023 • edited Loading

Android Examples from other Services

Elements / features used

michaelstingl commented Jun 2, 2023 • edited Loading

michaelstingl commented Jun 2, 2023

michaelstingl commented Jun 2, 2023

iOS Examples from other Services

Elements / features used

michaelstingl commented Jun 19, 2023 • edited Loading

michaelstingl commented Jun 19, 2023 • edited Loading

michaelstingl commented Jun 19, 2023 • edited Loading

michaelstingl commented Oct 25, 2023

michaelstingl commented Oct 25, 2023

Elements / features used

michaelstingl commented Nov 20, 2023

michaelstingl commented Nov 20, 2023

exalate-issue-sync bot commented May 31, 2023 •

edited

Loading

michaelstingl commented Jun 2, 2023 •

edited

Loading

michaelstingl commented Jun 2, 2023 •

edited

Loading

michaelstingl commented Jun 19, 2023 •

edited

Loading

michaelstingl commented Jun 19, 2023 •

edited

Loading

michaelstingl commented Jun 19, 2023 •

edited

Loading