Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CERN links #9210

Closed
Tracked by #7930
tbsbdr opened this issue Jun 13, 2023 · 6 comments
Closed
Tracked by #7930

Update CERN links #9210

tbsbdr opened this issue Jun 13, 2023 · 6 comments
Labels
Priority:p4-low Low priority Topic:Extensions-framework

Comments

@tbsbdr
Copy link

tbsbdr commented Jun 13, 2023 •
edited
Loading

needs to be made possible via extension system

screenshot_001219

fixed by: https://github.com/owncloud/web/pull/8473/files
relates to: 88a2efa
@tbsbdr tbsbdr closed this as completed Jun 13, 2023
@kulmann kulmann reopened this Jun 13, 2023
@kulmann
Copy link
Contributor

kulmann commented Jun 13, 2023

This is solved in a "workaround-way" in current web master. We want to have this properly implemented as an extension. I would like to keep the issue open to collect requirements. After that we can decide to close it again and create a followup issue for the proper extension solution.

@kulmann kulmann mentioned this issue Jun 13, 2023
Closed
30 tasks
@kulmann
Copy link
Contributor

kulmann commented Jun 16, 2023

TODO: document in a central place how to enable the feature

@tbsbdr tbsbdr added the Priority:p4-low Low priority label Jun 16, 2023
@pascalwengerter
Copy link
Contributor

@kulmann isRunningOnEos (which I supose is what enables this) is documented within https://owncloud.dev/clients/web/getting-started/#options

@dschmidt
Copy link
Member

dschmidt commented Nov 17, 2023 •
edited
Loading

in fact: it's implemented in an app now: https://github.com/cernbox/web-extensions/blob/18a735e406e06828f741283ede5a00866aca470d/cernbox-integration/src/index.ts#L20

@dschmidt
Copy link
Member

.. so it needs no config, the app just needs to be loaded

@pascalwengerter
Copy link
Contributor

In fact "something like this needs to be documented", so I'd include it in #9892 and close here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:p4-low Low priority Topic:Extensions-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dschmidt @kulmann @pascalwengerter @tbsbdr