Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Button Has No Hover-State #9354

Closed
tbsbdr opened this issue Jul 5, 2023 · 2 comments
Closed

Primary Button Has No Hover-State #9354

tbsbdr opened this issue Jul 5, 2023 · 2 comments
Assignees
Labels
Topic:good-first-issue beginner friendly task

Comments

@tbsbdr
Copy link

tbsbdr commented Jul 5, 2023

Steps to reproduce

  1. Hover over "New" Button
  2. Button Has No Hover-State

Expected behaviour

  • Primary button should have a hover state
    Light mode:
  • Darken on hover: decrease lightness of colors by 5% in HSL model
    (eg. hsl(213.06deg 52.69% 36.47%) minus 5% lightness→ hsl(213.06deg 52.69% 31.47%))
    Dark mode:
  • Lighten on hover: increase lightness of colors by 10% in HSL model
    (eg. hsl(213.06deg 52.69% 36.47%) plus 10% lightness→ (213.06deg 52.69% 46.47%))
screenshot_001350-converted.mp4
screenshot_001351.mp4

Actual behaviour

  • Button Has No Hover-State
@tbsbdr tbsbdr added the Topic:good-first-issue beginner friendly task label Jul 5, 2023
@grimmoc grimmoc self-assigned this Jul 6, 2023
@tbsbdr
Copy link
Author

tbsbdr commented Jul 6, 2023

@grimmoc grimmoc mentioned this issue Jul 12, 2023
10 tasks
@JammingBen
Copy link
Contributor

Fixed via #9394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic:good-first-issue beginner friendly task
Projects
None yet
Development

No branches or pull requests

3 participants