Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Show local loading spinner in sharing button #9425

Closed
exalate-issue-sync bot opened this issue Jul 17, 2023 · 0 comments · Fixed by #9423
Closed

[Web] Show local loading spinner in sharing button #9425

exalate-issue-sync bot opened this issue Jul 17, 2023 · 0 comments · Fixed by #9423
Labels

Comments

@exalate-issue-sync
Copy link

Description

User Stories

  • As a user who shares a file I want to know, that the system is workign so that i'm reassured that the app is workig.

Value

Acceptance Criteria

  • if a user clicks on "share" in the sharing pannel and the action takes longer than ~1 second (please try out what delay feels good), show a loading spinner before the button label
  • button gets a min-width that respects the realestate of the loading spinner

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants