Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test is failing because snapshots need to be updated #9659

Closed
SwikritiT opened this issue Sep 6, 2023 · 2 comments
Closed

unit test is failing because snapshots need to be updated #9659

SwikritiT opened this issue Sep 6, 2023 · 2 comments

Comments

@SwikritiT
Copy link
Contributor

SwikritiT commented Sep 6, 2023

The unit test pipeline is failing in CI on master because some snapshots weren't updated properly

Build link: https://drone.owncloud.com/owncloud/web/38551/8/4

Summary of all failing tests
FAIL packages/web-app-files/tests/unit/views/spaces/Projects.spec.ts (5.288 s)
  ● Projects view › different files view states › lists all available project spaces

    expect(received).toMatchSnapshot()

    Snapshot name: `Projects view different files view states lists all available project spaces 1`

    - Snapshot  - 0
    + Received  + 1

    @@ -9,10 +9,11 @@
                  <!--v-if-->
                  <input aria-invalid="false" autocomplete="off" class="oc-text-input oc-input oc-rounded" id="spaces-filter" type="text">
                  <!--v-if-->
                </div>
                <!--v-if-->
    +           <portal-target name="app.design-system.password-policy"></portal-target>
              </div>
              <resource-table-stub arepathsdisplayed="false" areresourcesclickable="true" arethumbnailsdisplayed="true" class="spaces-table" dragdrop="false" fieldsdisplayed="image,name,manager,members,totalQuota,usedQuota,remainingQuota,status,mdate" hasactions="true" headerposition="0" hover="true" isselectable="true" paddingx="small" resourcedomselector="[Function]" resources="" selectedids="" sort-fields="[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]" sortby="[Function]" sortdir="desc" sticky="false" viewmode="resource-table"></resource-table-stub>
            </div>
          </div>
        </div>

      69 |       // "space" is undefined for "space-context-actions", seems to be a bug because it's definitely not
      70 |       // {{ space }} -> undefined, {{ space.id }} -> "1"
    > 71 |       expect(wrapper.html()).toMatchSnapshot()
         |                              ^
      72 |       expect(wrapper.find('.no-content-message').exists()).toBeFalsy()
      73 |       expect(wrapper.find('.spaces-list').exists()).toBeTruthy()
      74 |     })

      at Object.<anonymous> (packages/web-app-files/tests/unit/views/spaces/Projects.spec.ts:71:30)


Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `npm run test:unit -- -u` to update them.

Test Suites: 1 failed, 1 skipped, 261 passed, 262 of 263 total
Tests:       1 failed, 7 skipped, 28 todo, 1895 passed, 1931 total
Snapshots:   1 failed, 159 passed, 160 total
Time:        143.118 s
Ran all test suites.
 ELIFECYCLE  Command failed with exit code 1.

the probably are failing because of the changes from PR #9649

@SwikritiT
Copy link
Contributor Author

SwikritiT commented Sep 6, 2023

cc @lookacat I think it's because of #9649 this PR so I'm pinging you

@SwikritiT
Copy link
Contributor Author

done in #9660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant