Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create User fails #9694

Closed
tbsbdr opened this issue Sep 14, 2023 · 3 comments · Fixed by #9703
Closed

Create User fails #9694

tbsbdr opened this issue Sep 14, 2023 · 3 comments · Fixed by #9703
Assignees
Labels
Priority:p3-medium Normal priority

Comments

@tbsbdr
Copy link

tbsbdr commented Sep 14, 2023

Steps to reproduce

  1. Try to create new user: Admin settings > Users > New User
  2. Enter Hänschen as user name, click Create button
  3. Error shows Failed to create user

screenshot_001669

Expected behaviour

  • Add validation to the user name field: Tell the user which characters are allowed
  • "Create" can only be clicked if the username is valid

Actual behaviour

  • Create User fails
@tbsbdr
Copy link
Author

tbsbdr commented Sep 14, 2023

cc @nicholas-wilson-au

@JammingBen
Copy link
Contributor

@micbar Could you provide us a list of characters that are not allowed in a username?

Ideally, the server would tell the client all the allowed characters, but for file names we don't have this either. Should be fine to hard-code such rules in Web (for now at least).

@tbsbdr
Copy link
Author

tbsbdr commented Sep 15, 2023

Hardcoding is fine for now I'd say 👍 we don't need to over-perform here.
Pointer where allowed characters are defined @JammingBen:
https://github.com/owncloud/ocis/blob/8cbf261568197a5494931357b5318d57b7134ae9/services/graph/pkg/service/v0/users.go#L742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants