open-with-web endpoint not working

[JuancaG05]

Describe the bug

For oCIS servers, the open-with-web endpoint is not working properly. I want to open a file in web, so I make the request to the server and when I receive the URL, the web is not able to open it (different errors in different servers).

Steps to reproduce

Steps to reproduce the behavior:

1. Make the POST request to open-with-web, sending the app name and the file ID as parameter
2. Receive the response and open the URL in the response
3. See the error in the web

Details:

REQUEST:
POST URL: https://ocis.ocis-wopi.latest.owncloud.works/app/open-with-web
file_id=fb004e32-d789-4a05-8215-d62f3f104b78%24016795a5-d04d-44a0-8f54-c7b07047717e%21a195f339-269e-406f-8fb0-587c2988fd6b&app_name=Collabora

RESPONSE
{"uri":"https://ocis.ocis-wopi.latest.owncloud.works/external?app=Collabora&contextRouteName=files-spaces-personal&fileId=fb004e32-d789-4a05-8215-d62f3f104b78%24016795a5-d04d-44a0-8f54-c7b07047717e%21a195f339-269e-406f-8fb0-587c2988fd6b"}

Expected behavior

The response returns a URL which opens the file in web correctly.

Actual behavior

The response returns a URL which doesn't open the file in web correctly, an error message appears saying Cannot read properties of null (reading ‘webDavPath’).

Setup

The server used is https://ocis.ocis-wopi.latest.owncloud.works

Additional context

This was tested from the Android app.
The same endpoint is working properly in oC10.
Also tested with https://ocis.ocis-web.latest.owncloud.works, and here the error is different (it cannot even open the web, it results in a 404 in the web).

CC @michaelstingl

[JammingBen]

I moved the issue to the Web repo because Web should be responsible for resolving the path correctly.

[JuancaG05]

Thanks @JammingBen! 🙏

[JammingBen]

@micbar I noticed that the URL coming from the server contains the param contextRouteName, however, the values are not correct anymore. Since Web will take care of correctly resolving the URL on its own, I suggest to completely remove that param.

Oh and since this is regarded as a critical bug, we will have a new Web version 7.1.1 soon, meaning we also need a new ocis release.

[micbar]

Ok, we can remove that parameter.

[michaelstingl]

Where's this deployed? It doesn't work for me on ocis.ocis-wopi.latest.owncloud.works yet. 🤔

[micbar]

Needs web bump in ocis.

[JammingBen]

Web v7.1.1 is available now. @micbar what would be the correct target branch in ocis for the Web bump? I assume master is already ahead and should not get this Web version.

[micbar]

Stable 4.0