Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the password requirement for the link breaks the "invite people via link" feature #9922

Closed
ScharfViktor opened this issue Nov 9, 2023 · 5 comments · Fixed by #9931
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Nov 9, 2023

related owncloud/ocis#7682

Steps:

  • run ocis with OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD=true (in my case It was as default)
  • create folder and click by copy link button and set the required password for the link (by default we create link with viewer permission). That means user with role user cannot create link with
  • share folder to einstein
  • change link permission to invited people

Expected

  • invited people is on the list of roles for the link
  • If the link role gets downgraded from "anyone can..." to "Only Invited ...", password and exp. date gets removed from the link

Current behaviour

no invited people in the list. You can only get this permission if you delete password for link (admin feature)
Note: using api we can create public link with permission 0 (invite people) without password: - is correct
image

Screen.Recording.2023-11-09.at.06.18.20.mov
@ScharfViktor ScharfViktor added the Type:Bug Something isn't working label Nov 9, 2023
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Nov 9, 2023
@kulmann kulmann moved this from Qualification to Prio 2 in Infinite Scale Team Board Nov 9, 2023
@kulmann
Copy link
Contributor

kulmann commented Nov 9, 2023

@ScharfViktor is it possible for a non-admin to update the link to permission: 0 and removing the password on an API level? Then we could solve it web-only.

@tbsbdr
Copy link

tbsbdr commented Nov 9, 2023

update: added more details to expected behaviour in initial post of yours, @ScharfViktor

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor is it possible for a non-admin to update the link to permission: 0 and removing the password on an API level? Then we could solve it web-only.

yes, non-admin can update link
Screenshot 2023-11-09 at 11 45 43

@kulmann
Copy link
Contributor

kulmann commented Nov 9, 2023

@jacob-nv is this something you could take over?

@jacob-nv jacob-nv self-assigned this Nov 9, 2023
@jacob-nv
Copy link
Contributor

jacob-nv commented Nov 9, 2023

@jacob-nv is this something you could take over?

For sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants