Search filter "in here" only applies together with search term

[kulmann]

Describe the bug

The search filter "in here" from the search input field only applies together with a search term, not with empty search term but other filters.

Steps to reproduce

1. Have two "test.md" files, one in your personal space and one in a project space
2. Navigate into the project space
3. Select "in here" in the search input field and trigger the search (enter / click on the magnifier icon)
4. Select a media type filter for "Documents" (which includes markdown)

Expected behavior

Search result only shows documents from the project space

Actual behavior

Search result also shows the "test.md" file from your personal space. Adding "test" as a search term successfully adds the "in here" location filter as well.

[jacob-nv]

Any ideas how to go about this?
Having empty query removes "scope", which is why empty search with "in here" searches everywhere.
Tried forcing the search with empty query, but that throws error from WebDAV

[lookacat]

@kulmann i think then we either can't fix it or we need a backend ticket
(and not sure if that would be doable in this sprint for backend)

[kulmann]

Correct, I'd say this is a backend bug. The only thing to do in the frontend would be to remove this line:

web/packages/web-app-search/src/portals/SearchBar.vue

Line 223 in 22ea1b4

unref(term) &&

But then this backend issue happens:
owncloud/ocis#7812

[kulmann]

@jacob-nv could you please try the solution posted in owncloud/ocis#7812 (comment) ?