Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize oc10 preview providers for allowed mime types in preview app #6933

Closed
kulmann opened this issue May 10, 2022 · 2 comments · Fixed by #7131
Closed

utilize oc10 preview providers for allowed mime types in preview app #6933

kulmann opened this issue May 10, 2022 · 2 comments · Fixed by #7131

Comments

@kulmann
Copy link
Member

kulmann commented May 10, 2022

ownCloud 10 lets admins define preview providers in the config.php file, see e.g. https://github.com/owncloud/files_mediaviewer#supporting-more-media-types for details

For the preview app we should utilize this for automatically registering additional supported file types.

When we introduce configuration management for web, we could inject preview provider settings into the config.json endpoint of the web-oc10-integration app.

@kulmann
Copy link
Member Author

kulmann commented May 31, 2022

Since I've heard frustration about the complexity of the proposed solution: a simple first step to achieve the same is to allow configuring the preview providers in the config.json of ownCloud Web. I.e. configure it in config.php server side and in config.json client side.

@mmattel
Copy link
Contributor

mmattel commented Jun 2, 2022

Imho it is important to differenciate based on experience, if I recall properly:

  1. The preview provider is able to create thumbnails for multimedia formats which are then shown in the web ui.
    This is easy because you can add items in config.php if available and enable thumbnail rendering if necessary in the imagick config. This is all documented.
  2. When the file gets clicked and the browser can disply the format, the file gets previewed by the browser but gets downloaded if the browser is not capable.
    This implies that for each format to be previewed, the frontend needs to be capable to do so. This is documented too.

The question is, which media formats need to be added to be shown, satisfying which topic above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants