Skip to content

Commit 00d8792

Browse files
camc314camc314
committed
fix codegen regression
1 parent 7b7c1c0 commit 00d8792

File tree

4 files changed

+4
-120
lines changed

4 files changed

+4
-120
lines changed

‎crates/oxc_codegen/src/gen.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3515,7 +3515,7 @@ impl Gen for TSTypeQueryExprName<'_> {
35153515
impl Gen for TSImportType<'_> {
35163516
fn r#gen(&self, p: &mut Codegen, ctx: Context) {
35173517
p.print_str("import(");
3518-
self.source.print(p, ctx);
3518+
p.print_string_literal(&self.source, false);
35193519
if let Some(options) = &self.options {
35203520
p.print_str(", ");
35213521
options.print_expr(p, Precedence::Lowest, ctx);

‎tasks/coverage/snapshots/codegen_babel.snap‎

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -2,40 +2,8 @@ commit: 99dcba5e
22

33
codegen_babel Summary:
44
AST Parsed : 2440/2440 (100.00%)
5-
Positive Passed: 2422/2440 (99.26%)
5+
Positive Passed: 2438/2440 (99.92%)
66
Normal: tasks/coverage/babel/packages/babel-parser/test/fixtures/core/uncategorised/47/input.js
77

88
Normal: tasks/coverage/babel/packages/babel-parser/test/fixtures/core/uncategorised/48/input.js
99

10-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/estree/typescript/import/input.js
11-
12-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/estree/typescript/import-babel-7/input.js
13-
14-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/estree/typescript/import-dot-this/input.js
15-
16-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/estree/typescript/import-dot-this-babel-7/input.js
17-
18-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/estree/typescript/import-with-options/input.js
19-
20-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/estree/typescript/import-with-options-babel-7/input.js
21-
22-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic/input.ts
23-
24-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-babel-7/input.ts
25-
26-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-with-options/input.ts
27-
28-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-with-options-babel-7/input.ts
29-
30-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-with-options-trailing-comma/input.ts
31-
32-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-with-options-trailing-comma-babel-7/input.ts
33-
34-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-with-string-options/input.ts
35-
36-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-dynamic-with-string-options-babel-7/input.ts
37-
38-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-options-with-trailing-comma/input.ts
39-
40-
Minify: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/types/import-type-options-with-trailing-comma-babel-7/input.ts
41-

‎tasks/coverage/snapshots/codegen_misc.snap‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
11
codegen_misc Summary:
22
AST Parsed : 52/52 (100.00%)
3-
Positive Passed: 50/52 (96.15%)
4-
Minify: tasks/coverage/misc/pass/oxc-13284.ts
5-
6-
Minify: tasks/coverage/misc/pass/oxc-2394.ts
7-
3+
Positive Passed: 52/52 (100.00%)

‎tasks/coverage/snapshots/codegen_typescript.snap‎

Lines changed: 1 addition & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -2,84 +2,4 @@ commit: 669c25c0
22

33
codegen_typescript Summary:
44
AST Parsed : 9822/9822 (100.00%)
5-
Positive Passed: 9782/9822 (99.59%)
6-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitCrossFileCopiedGeneratedImportType.ts
7-
8-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitForGlobalishSpecifierSymlink.ts
9-
10-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitForGlobalishSpecifierSymlink2.ts
11-
12-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitIsolatedDeclarationErrorNotEmittedForNonEmittedFile.ts
13-
14-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitNoInvalidCommentReuse1.ts
15-
16-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitNoInvalidCommentReuse2.ts
17-
18-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitTopLevelNodeFromCrossFile2.ts
19-
20-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitTripleSlashReferenceAmbientModule.ts
21-
22-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitUsingTypeAlias1.ts
23-
24-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitUsingTypeAlias2.ts
25-
26-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationEmitWithInvalidPackageJsonTypings.ts
27-
28-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationImportTypeAliasInferredAndEmittable.ts
29-
30-
Minify: tasks/coverage/typescript/tests/cases/compiler/declarationsForInferredTypeFromOtherFile.ts
31-
32-
Minify: tasks/coverage/typescript/tests/cases/compiler/exportAssignmentExpressionIsExpressionNode.ts
33-
34-
Minify: tasks/coverage/typescript/tests/cases/compiler/importTypeTypeofClassStaticLookup.ts
35-
36-
Minify: tasks/coverage/typescript/tests/cases/compiler/importTypeWithUnparenthesizedGenericFunctionParsed.ts
37-
38-
Minify: tasks/coverage/typescript/tests/cases/compiler/importUsedAsTypeWithErrors.ts
39-
40-
Minify: tasks/coverage/typescript/tests/cases/compiler/importUsedInGenericImportResolves.ts
41-
42-
Minify: tasks/coverage/typescript/tests/cases/compiler/jsDocDeclarationEmitDoesNotUseNodeModulesPathWithoutError.ts
43-
44-
Minify: tasks/coverage/typescript/tests/cases/compiler/metadataImportType.ts
45-
46-
Minify: tasks/coverage/typescript/tests/cases/compiler/moduleResolutionWithRequireAndImport.ts
47-
48-
Minify: tasks/coverage/typescript/tests/cases/compiler/nestedGenericConditionalTypeWithGenericImportType.ts
49-
50-
Minify: tasks/coverage/typescript/tests/cases/compiler/reuseTypeAnnotationImportTypeInGlobalThisTypeArgument.ts
51-
52-
Minify: tasks/coverage/typescript/tests/cases/compiler/spuriousCircularityOnTypeImport.ts
53-
54-
Minify: tasks/coverage/typescript/tests/cases/compiler/symbolLinkDeclarationEmitModuleNamesImportRef.ts
55-
56-
Minify: tasks/coverage/typescript/tests/cases/compiler/typeofImportInstantiationExpression.ts
57-
58-
Minify: tasks/coverage/typescript/tests/cases/compiler/unmetTypeConstraintInImportCall.ts
59-
60-
Minify: tasks/coverage/typescript/tests/cases/conformance/externalModules/typeOnly/allowsImportingTsExtension.ts
61-
62-
Minify: tasks/coverage/typescript/tests/cases/conformance/externalModules/typeOnly/typeOnlyESMImportFromCJS.ts
63-
64-
Minify: tasks/coverage/typescript/tests/cases/conformance/moduleResolution/allowImportingTypesDtsExtension.ts
65-
66-
Minify: tasks/coverage/typescript/tests/cases/conformance/moduleResolution/resolutionModeImportType1.ts
67-
68-
Minify: tasks/coverage/typescript/tests/cases/conformance/node/nodeModulesImportAttributesTypeModeDeclarationEmit.ts
69-
70-
Minify: tasks/coverage/typescript/tests/cases/conformance/node/nodeModulesImportTypeModeDeclarationEmit1.ts
71-
72-
Minify: tasks/coverage/typescript/tests/cases/conformance/salsa/moduleExportAssignment7.ts
73-
74-
Minify: tasks/coverage/typescript/tests/cases/conformance/types/import/importTypeAmbient.ts
75-
76-
Minify: tasks/coverage/typescript/tests/cases/conformance/types/import/importTypeAmbientMissing.ts
77-
78-
Minify: tasks/coverage/typescript/tests/cases/conformance/types/import/importTypeAmdBundleRewrite.ts
79-
80-
Minify: tasks/coverage/typescript/tests/cases/conformance/types/import/importTypeGenericTypes.ts
81-
82-
Minify: tasks/coverage/typescript/tests/cases/conformance/types/import/importTypeLocal.ts
83-
84-
Minify: tasks/coverage/typescript/tests/cases/conformance/types/import/importTypeLocalMissing.ts
85-
5+
Positive Passed: 9822/9822 (100.00%)

0 commit comments

Comments
 (0)