Skip to content

Commit 0630d68

Browse files
committed
build(linter): build oxlint locally with Mimalloc in release mode (#14034)
Previously we built `oxlint` with Mimalloc enabled (`--features allocator`) when creating a public release, but we didn't enable Mimalloc in local release builds. That's not ideal, as we often build in release mode locally to benchmark `oxlint`'s perf on large repos e.g. VS Code. Always enable Mimalloc when building `oxlint` in release mode.
1 parent 0d48511 commit 0630d68

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/release_oxlint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ jobs:
117117

118118
- name: Build oxlint
119119
working-directory: apps/oxlint
120-
run: ${{ matrix.build-oxlint }} --features allocator
120+
run: ${{ matrix.build-oxlint }}
121121
shell: bash
122122
env:
123123
TARGET_CC: clang # for mimalloc

apps/oxlint/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"build-test": "pnpm run build-napi-test && pnpm run build-js",
1111
"build-napi": "napi build --esm --platform --js ./bindings.js --dts ./bindings.d.ts --output-dir src-js --no-dts-cache",
1212
"build-napi-test": "pnpm run build-napi --features force_test_reporter",
13-
"build-napi-release": "pnpm run build-napi --release",
13+
"build-napi-release": "pnpm run build-napi --release --features allocator",
1414
"build-js": "node scripts/build.js",
1515
"test": "tsc && vitest --dir ./test run"
1616
},

0 commit comments

Comments
 (0)