refactor(oxlint2): introduce force_test_reporter feature for consistent graphical outputs (#12133)

Author: camc314

apps/oxlint/Cargo.toml

@@ -62,3 +62,4 @@ default = []
 allocator = ["dep:mimalloc-safe"]
 oxlint2 = ["oxc_linter/oxlint2"]
 disable_oxlint2 = ["oxc_linter/disable_oxlint2"]
+force_test_reporter = ["oxc_linter/force_test_reporter"]

apps/oxlint/src/lint.rs

@@ -172,7 +172,11 @@ impl Runner for LintRunner {
         let paths = walker.paths();
         let number_of_files = paths.len();
 
-        let handler = GraphicalReportHandler::new();
+        let handler = if cfg!(any(test, feature = "force_test_reporter")) {
+            GraphicalReportHandler::new_themed(miette::GraphicalTheme::none())
+        } else {
+            GraphicalReportHandler::new()
+        };
 
         let search_for_nested_configs = !disable_nested_config &&
             // If the `--config` option is explicitly passed, we should not search for nested config files

apps/oxlint/src/output_formatter/default.rs

@@ -40,12 +40,12 @@ impl InternalFormatter for DefaultOutputFormatter {
         }
     }
 
-    #[cfg(not(test))]
+    #[cfg(not(any(test, feature = "force_test_reporter")))]
     fn get_diagnostic_reporter(&self) -> Box<dyn DiagnosticReporter> {
         Box::new(GraphicalReporter::default())
     }
 
-    #[cfg(test)]
+    #[cfg(any(test, feature = "force_test_reporter"))]
     fn get_diagnostic_reporter(&self) -> Box<dyn DiagnosticReporter> {
         use crate::output_formatter::default::test_implementation::GraphicalReporterTester;
 
@@ -113,7 +113,7 @@ fn get_diagnostic_result_output(result: &DiagnosticResult) -> String {
     output
 }
 
-#[cfg(test)]
+#[cfg(any(test, feature = "force_test_reporter"))]
 mod test_implementation {
     use oxc_diagnostics::{
         Error, GraphicalReportHandler, GraphicalTheme,

crates/oxc_linter/Cargo.toml

@@ -19,6 +19,7 @@ ruledocs = ["oxc_macros/ruledocs"] # Enables the `ruledocs` feature for conditio
 language_server = ["oxc_data_structures/rope"] # For the Runtime to support needed information for the language server
 oxlint2 = []
 disable_oxlint2 = []
+force_test_reporter = []
 
 [lints]
 workspace = true

napi/oxlint2/Cargo.toml

@@ -42,3 +42,4 @@ napi-build = { workspace = true }
 
 [features]
 default = []
+force_test_reporter = ["oxlint/force_test_reporter"]

napi/oxlint2/package.json

@@ -5,7 +5,7 @@
   "type": "module",
   "scripts": {
     "build-dev": "napi build --platform --js ./bindings.js --dts ./bindings.d.ts --output-dir src --no-dts-cache --esm",
-    "build-test": "pnpm run build-dev --release",
+    "build-test": "pnpm run build-dev --release --features force_test_reporter",
     "build": "pnpm run build-dev --release",
     "test": "vitest"
   },