refactor(ast): don't generate AstKind for ArrayExpressionElement (#11684)

Part of #11490

Author: ulrichstark

crates/oxc_ast/src/ast_kind_impl.rs

@@ -244,7 +244,6 @@ impl AstKind<'_> {
             }
             Self::PropertyKey(p) => format!("PropertyKey({})", p.name().unwrap_or(COMPUTED)).into(),
             Self::Argument(_) => "Argument".into(),
-            Self::ArrayExpressionElement(_) => "ArrayExpressionElement".into(),
             Self::AssignmentTarget(_) => "AssignmentTarget".into(),
             Self::SimpleAssignmentTarget(a) => {
                 format!("SimpleAssignmentTarget({})", a.get_identifier_name().unwrap_or(&UNKNOWN))

crates/oxc_ast/src/generated/ast_kind.rs

@@ -20,170 +20,169 @@ pub enum AstType {
     LabelIdentifier = 4,
     ThisExpression = 5,
     ArrayExpression = 6,
-    ArrayExpressionElement = 7,
-    Elision = 8,
-    ObjectExpression = 9,
-    ObjectProperty = 10,
-    PropertyKey = 11,
-    TemplateLiteral = 12,
-    TaggedTemplateExpression = 13,
-    MemberExpression = 14,
-    CallExpression = 15,
-    NewExpression = 16,
-    MetaProperty = 17,
-    SpreadElement = 18,
-    Argument = 19,
-    UpdateExpression = 20,
-    UnaryExpression = 21,
-    BinaryExpression = 22,
-    PrivateInExpression = 23,
-    LogicalExpression = 24,
-    ConditionalExpression = 25,
-    AssignmentExpression = 26,
-    AssignmentTarget = 27,
-    SimpleAssignmentTarget = 28,
-    AssignmentTargetPattern = 29,
-    ArrayAssignmentTarget = 30,
-    ObjectAssignmentTarget = 31,
-    AssignmentTargetWithDefault = 32,
-    SequenceExpression = 33,
-    Super = 34,
-    AwaitExpression = 35,
-    ChainExpression = 36,
-    ParenthesizedExpression = 37,
-    Directive = 38,
-    Hashbang = 39,
-    BlockStatement = 40,
-    VariableDeclaration = 41,
-    VariableDeclarator = 42,
-    EmptyStatement = 43,
-    ExpressionStatement = 44,
-    IfStatement = 45,
-    DoWhileStatement = 46,
-    WhileStatement = 47,
-    ForStatement = 48,
-    ForInStatement = 49,
-    ForOfStatement = 50,
-    ContinueStatement = 51,
-    BreakStatement = 52,
-    ReturnStatement = 53,
-    WithStatement = 54,
-    SwitchStatement = 55,
-    SwitchCase = 56,
-    LabeledStatement = 57,
-    ThrowStatement = 58,
-    TryStatement = 59,
-    CatchClause = 60,
-    CatchParameter = 61,
-    DebuggerStatement = 62,
-    AssignmentPattern = 63,
-    ObjectPattern = 64,
-    ArrayPattern = 65,
-    BindingRestElement = 66,
-    Function = 67,
-    FormalParameters = 68,
-    FormalParameter = 69,
-    FunctionBody = 70,
-    ArrowFunctionExpression = 71,
-    YieldExpression = 72,
-    Class = 73,
-    ClassBody = 74,
-    MethodDefinition = 75,
-    PropertyDefinition = 76,
-    PrivateIdentifier = 77,
-    StaticBlock = 78,
-    ModuleDeclaration = 79,
-    ImportExpression = 80,
-    ImportDeclaration = 81,
-    ImportSpecifier = 82,
-    ImportDefaultSpecifier = 83,
-    ImportNamespaceSpecifier = 84,
-    ExportNamedDeclaration = 85,
-    ExportDefaultDeclaration = 86,
-    ExportAllDeclaration = 87,
-    ExportSpecifier = 88,
-    V8IntrinsicExpression = 89,
-    BooleanLiteral = 90,
-    NullLiteral = 91,
-    NumericLiteral = 92,
-    StringLiteral = 93,
-    BigIntLiteral = 94,
-    RegExpLiteral = 95,
-    JSXElement = 96,
-    JSXOpeningElement = 97,
-    JSXClosingElement = 98,
-    JSXFragment = 99,
-    JSXOpeningFragment = 100,
-    JSXClosingFragment = 101,
-    JSXNamespacedName = 102,
-    JSXMemberExpression = 103,
-    JSXExpressionContainer = 104,
-    JSXEmptyExpression = 105,
-    JSXAttribute = 106,
-    JSXSpreadAttribute = 107,
-    JSXIdentifier = 108,
-    JSXSpreadChild = 109,
-    JSXText = 110,
-    TSThisParameter = 111,
-    TSEnumDeclaration = 112,
-    TSEnumBody = 113,
-    TSEnumMember = 114,
-    TSTypeAnnotation = 115,
-    TSLiteralType = 116,
-    TSConditionalType = 117,
-    TSUnionType = 118,
-    TSIntersectionType = 119,
-    TSParenthesizedType = 120,
-    TSIndexedAccessType = 121,
-    TSNamedTupleMember = 122,
-    TSAnyKeyword = 123,
-    TSStringKeyword = 124,
-    TSBooleanKeyword = 125,
-    TSNumberKeyword = 126,
-    TSNeverKeyword = 127,
-    TSIntrinsicKeyword = 128,
-    TSUnknownKeyword = 129,
-    TSNullKeyword = 130,
-    TSUndefinedKeyword = 131,
-    TSVoidKeyword = 132,
-    TSSymbolKeyword = 133,
-    TSThisType = 134,
-    TSObjectKeyword = 135,
-    TSBigIntKeyword = 136,
-    TSTypeReference = 137,
-    TSTypeName = 138,
-    TSQualifiedName = 139,
-    TSTypeParameterInstantiation = 140,
-    TSTypeParameter = 141,
-    TSTypeParameterDeclaration = 142,
-    TSTypeAliasDeclaration = 143,
-    TSClassImplements = 144,
-    TSInterfaceDeclaration = 145,
-    TSPropertySignature = 146,
-    TSMethodSignature = 147,
-    TSConstructSignatureDeclaration = 148,
-    TSInterfaceHeritage = 149,
-    TSModuleDeclaration = 150,
-    TSModuleBlock = 151,
-    TSTypeLiteral = 152,
-    TSInferType = 153,
-    TSTypeQuery = 154,
-    TSImportType = 155,
-    TSMappedType = 156,
-    TSTemplateLiteralType = 157,
-    TSAsExpression = 158,
-    TSSatisfiesExpression = 159,
-    TSTypeAssertion = 160,
-    TSImportEqualsDeclaration = 161,
-    TSModuleReference = 162,
-    TSExternalModuleReference = 163,
-    TSNonNullExpression = 164,
-    Decorator = 165,
-    TSExportAssignment = 166,
-    TSInstantiationExpression = 167,
-    JSDocNullableType = 168,
-    JSDocNonNullableType = 169,
-    JSDocUnknownType = 170,
+    Elision = 7,
+    ObjectExpression = 8,
+    ObjectProperty = 9,
+    PropertyKey = 10,
+    TemplateLiteral = 11,
+    TaggedTemplateExpression = 12,
+    MemberExpression = 13,
+    CallExpression = 14,
+    NewExpression = 15,
+    MetaProperty = 16,
+    SpreadElement = 17,
+    Argument = 18,
+    UpdateExpression = 19,
+    UnaryExpression = 20,
+    BinaryExpression = 21,
+    PrivateInExpression = 22,
+    LogicalExpression = 23,
+    ConditionalExpression = 24,
+    AssignmentExpression = 25,
+    AssignmentTarget = 26,
+    SimpleAssignmentTarget = 27,
+    AssignmentTargetPattern = 28,
+    ArrayAssignmentTarget = 29,
+    ObjectAssignmentTarget = 30,
+    AssignmentTargetWithDefault = 31,
+    SequenceExpression = 32,
+    Super = 33,
+    AwaitExpression = 34,
+    ChainExpression = 35,
+    ParenthesizedExpression = 36,
+    Directive = 37,
+    Hashbang = 38,
+    BlockStatement = 39,
+    VariableDeclaration = 40,
+    VariableDeclarator = 41,
+    EmptyStatement = 42,
+    ExpressionStatement = 43,
+    IfStatement = 44,
+    DoWhileStatement = 45,
+    WhileStatement = 46,
+    ForStatement = 47,
+    ForInStatement = 48,
+    ForOfStatement = 49,
+    ContinueStatement = 50,
+    BreakStatement = 51,
+    ReturnStatement = 52,
+    WithStatement = 53,
+    SwitchStatement = 54,
+    SwitchCase = 55,
+    LabeledStatement = 56,
+    ThrowStatement = 57,
+    TryStatement = 58,
+    CatchClause = 59,
+    CatchParameter = 60,
+    DebuggerStatement = 61,
+    AssignmentPattern = 62,
+    ObjectPattern = 63,
+    ArrayPattern = 64,
+    BindingRestElement = 65,
+    Function = 66,
+    FormalParameters = 67,
+    FormalParameter = 68,
+    FunctionBody = 69,
+    ArrowFunctionExpression = 70,
+    YieldExpression = 71,
+    Class = 72,
+    ClassBody = 73,
+    MethodDefinition = 74,
+    PropertyDefinition = 75,
+    PrivateIdentifier = 76,
+    StaticBlock = 77,
+    ModuleDeclaration = 78,
+    ImportExpression = 79,
+    ImportDeclaration = 80,
+    ImportSpecifier = 81,
+    ImportDefaultSpecifier = 82,
+    ImportNamespaceSpecifier = 83,
+    ExportNamedDeclaration = 84,
+    ExportDefaultDeclaration = 85,
+    ExportAllDeclaration = 86,
+    ExportSpecifier = 87,
+    V8IntrinsicExpression = 88,
+    BooleanLiteral = 89,
+    NullLiteral = 90,
+    NumericLiteral = 91,
+    StringLiteral = 92,
+    BigIntLiteral = 93,
+    RegExpLiteral = 94,
+    JSXElement = 95,
+    JSXOpeningElement = 96,
+    JSXClosingElement = 97,
+    JSXFragment = 98,
+    JSXOpeningFragment = 99,
+    JSXClosingFragment = 100,
+    JSXNamespacedName = 101,
+    JSXMemberExpression = 102,
+    JSXExpressionContainer = 103,
+    JSXEmptyExpression = 104,
+    JSXAttribute = 105,
+    JSXSpreadAttribute = 106,
+    JSXIdentifier = 107,
+    JSXSpreadChild = 108,
+    JSXText = 109,
+    TSThisParameter = 110,
+    TSEnumDeclaration = 111,
+    TSEnumBody = 112,
+    TSEnumMember = 113,
+    TSTypeAnnotation = 114,
+    TSLiteralType = 115,
+    TSConditionalType = 116,
+    TSUnionType = 117,
+    TSIntersectionType = 118,
+    TSParenthesizedType = 119,
+    TSIndexedAccessType = 120,
+    TSNamedTupleMember = 121,
+    TSAnyKeyword = 122,
+    TSStringKeyword = 123,
+    TSBooleanKeyword = 124,
+    TSNumberKeyword = 125,
+    TSNeverKeyword = 126,
+    TSIntrinsicKeyword = 127,
+    TSUnknownKeyword = 128,
+    TSNullKeyword = 129,
+    TSUndefinedKeyword = 130,
+    TSVoidKeyword = 131,
+    TSSymbolKeyword = 132,
+    TSThisType = 133,
+    TSObjectKeyword = 134,
+    TSBigIntKeyword = 135,
+    TSTypeReference = 136,
+    TSTypeName = 137,
+    TSQualifiedName = 138,
+    TSTypeParameterInstantiation = 139,
+    TSTypeParameter = 140,
+    TSTypeParameterDeclaration = 141,
+    TSTypeAliasDeclaration = 142,
+    TSClassImplements = 143,
+    TSInterfaceDeclaration = 144,
+    TSPropertySignature = 145,
+    TSMethodSignature = 146,
+    TSConstructSignatureDeclaration = 147,
+    TSInterfaceHeritage = 148,
+    TSModuleDeclaration = 149,
+    TSModuleBlock = 150,
+    TSTypeLiteral = 151,
+    TSInferType = 152,
+    TSTypeQuery = 153,
+    TSImportType = 154,
+    TSMappedType = 155,
+    TSTemplateLiteralType = 156,
+    TSAsExpression = 157,
+    TSSatisfiesExpression = 158,
+    TSTypeAssertion = 159,
+    TSImportEqualsDeclaration = 160,
+    TSModuleReference = 161,
+    TSExternalModuleReference = 162,
+    TSNonNullExpression = 163,
+    Decorator = 164,
+    TSExportAssignment = 165,
+    TSInstantiationExpression = 166,
+    JSDocNullableType = 167,
+    JSDocNonNullableType = 168,
+    JSDocUnknownType = 169,
 }
 
 /// Untyped AST Node Kind
@@ -197,7 +196,6 @@ pub enum AstKind<'a> {
     LabelIdentifier(&'a LabelIdentifier<'a>) = AstType::LabelIdentifier as u8,
     ThisExpression(&'a ThisExpression) = AstType::ThisExpression as u8,
     ArrayExpression(&'a ArrayExpression<'a>) = AstType::ArrayExpression as u8,
-    ArrayExpressionElement(&'a ArrayExpressionElement<'a>) = AstType::ArrayExpressionElement as u8,
     Elision(&'a Elision) = AstType::Elision as u8,
     ObjectExpression(&'a ObjectExpression<'a>) = AstType::ObjectExpression as u8,
     ObjectProperty(&'a ObjectProperty<'a>) = AstType::ObjectProperty as u8,
@@ -398,7 +396,6 @@ impl GetSpan for AstKind<'_> {
             Self::LabelIdentifier(it) => it.span(),
             Self::ThisExpression(it) => it.span(),
             Self::ArrayExpression(it) => it.span(),
-            Self::ArrayExpressionElement(it) => it.span(),
             Self::Elision(it) => it.span(),
             Self::ObjectExpression(it) => it.span(),
             Self::ObjectProperty(it) => it.span(),
@@ -602,11 +599,6 @@ impl<'a> AstKind<'a> {
         if let Self::ArrayExpression(v) = self { Some(v) } else { None }
     }
 
-    #[inline]
-    pub fn as_array_expression_element(self) -> Option<&'a ArrayExpressionElement<'a>> {
-        if let Self::ArrayExpressionElement(v) = self { Some(v) } else { None }
-    }
-
     #[inline]
     pub fn as_elision(self) -> Option<&'a Elision> {
         if let Self::Elision(v) = self { Some(v) } else { None }

crates/oxc_ast_visit/src/generated/visit.rs

@@ -1473,16 +1473,14 @@ pub mod walk {
         visitor: &mut V,
         it: &ArrayExpressionElement<'a>,
     ) {
-        let kind = AstKind::ArrayExpressionElement(visitor.alloc(it));
-        visitor.enter_node(kind);
+        // No `AstKind` for this type
         match it {
             ArrayExpressionElement::SpreadElement(it) => visitor.visit_spread_element(it),
             ArrayExpressionElement::Elision(it) => visitor.visit_elision(it),
             match_expression!(ArrayExpressionElement) => {
                 visitor.visit_expression(it.to_expression())
             }
         }
-        visitor.leave_node(kind);
     }
 
     #[inline]