fix(minifier): incorrect non-null object condition simplification with && and ||

Author: sapphi-red

crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs

@@ -406,6 +406,9 @@ impl<'a> PeepholeOptimizations {
         let Expression::LogicalExpression(left) = &e.left else {
             return;
         };
+        if left.operator != e.operator {
+            return;
+        }
         let Some(new_expr) = Self::try_compress_is_object_and_not_null_for_left_and_right(
             &left.right,
             &e.right,
@@ -2143,6 +2146,24 @@ mod test {
             "var foo, bar; v = bar !== 1 && typeof foo === 'object' && foo !== null",
             "var foo, bar; v = bar !== 1 && typeof foo == 'object' && !!foo",
         );
+        test(
+            "var foo, bar; v = typeof foo === 'object' && foo !== null || bar !== 1",
+            "var foo, bar; v = typeof foo == 'object' && !!foo || bar !== 1",
+        );
+        test(
+            "var foo, bar; v = bar !== 1 || typeof foo === 'object' && foo !== null",
+            "var foo, bar; v = bar !== 1 || typeof foo == 'object' && !!foo",
+        );
+        test(
+            "var foo, bar; v = (typeof foo !== 'object' || foo === null) && bar !== 1",
+            "var foo, bar; v = (typeof foo != 'object' || !foo) && bar !== 1",
+        );
+        test(
+            "var foo, bar; v = bar !== 1 && (typeof foo !== 'object' || foo === null)",
+            "var foo, bar; v = bar !== 1 && (typeof foo != 'object' || !foo)",
+        );
+        test_same("var foo, bar; v = bar !== 1 && typeof foo != 'object' || foo === null");
+        test_same("var foo, bar; v = typeof foo != 'object' || foo === null && bar !== 1");
         test_same("var foo; v = typeof foo.a == 'object' && foo.a !== null"); // cannot be folded because accessing foo.a might have a side effect
         test_same("v = foo !== null && typeof foo == 'object'"); // cannot be folded because accessing foo might have a side effect
         test_same("v = typeof foo == 'object' && foo !== null"); // cannot be folded because accessing foo might have a side effect