feat(semantic): add symbol_id to ts function type binding idents

camc314 · camc314 · commit 3a835b4e30a6 · 2025-10-17T02:07:27.000Z
diff --git a/crates/oxc_linter/src/rules/eslint/no_unused_vars/mod.rs b/crates/oxc_linter/src/rules/eslint/no_unused_vars/mod.rs
@@ -357,6 +357,15 @@ impl NoUnusedVars {
             return true;
         }
 
+        let node_id = symbol.declaration().id();
+        if flags.intersects(SymbolFlags::FunctionScopedVariable)
+            && let AstKind::FormalParameters(formal_parameters) =
+                symbol.nodes().parent_node(node_id).kind()
+            && formal_parameters.kind.is_signature()
+        {
+            return true;
+        }
+
         // In some cases (e.g. "jsx": "react" in tsconfig.json), React imports
         // get used in generated code. We don't have a way to detect
         // "jsxPragmas" or whether TSX files are using "jsx": "react-jsx", so we
diff --git a/crates/oxc_semantic/src/binder.rs b/crates/oxc_semantic/src/binder.rs
@@ -185,14 +185,10 @@ impl<'a> Binder<'a> for BindingRestElement<'a> {
     // Binds the FormalParameters's rest of a function or method.
     fn bind(&self, builder: &mut SemanticBuilder) {
         let parent_kind = builder.nodes.parent_kind(builder.current_node_id);
-        let AstKind::FormalParameters(parameters) = parent_kind else {
+        let AstKind::FormalParameters(_) = parent_kind else {
             return;
         };
 
-        if parameters.kind.is_signature() {
-            return;
-        }
-
         let includes = SymbolFlags::FunctionScopedVariable;
         let excludes =
             SymbolFlags::FunctionScopedVariable | SymbolFlags::FunctionScopedVariableExcludes;
@@ -209,10 +205,6 @@ impl<'a> Binder<'a> for FormalParameter<'a> {
         let parent_kind = builder.nodes.parent_kind(builder.current_node_id);
         let AstKind::FormalParameters(parameters) = parent_kind else { unreachable!() };
 
-        if parameters.kind.is_signature() {
-            return;
-        }
-
         let includes = SymbolFlags::FunctionScopedVariable;
 
         let is_not_allowed_duplicate_parameters = matches!(
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/decorators/class-deco-with-object-param.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/decorators/class-deco-with-object-param.snap
@@ -12,7 +12,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/decorators/clas
             "flags": "ScopeFlags(StrictMode)",
             "id": 2,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "param",
+                "node": "BindingRestElement",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode | Function)",
@@ -56,7 +64,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/decorators/clas
       },
       {
         "flags": "SymbolFlags(Class)",
-        "id": 2,
+        "id": 3,
         "name": "Foo",
         "node": "Class(Foo)",
         "references": []
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/conditional3.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/conditional3.snap
@@ -14,7 +14,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
                 "flags": "ScopeFlags(StrictMode)",
                 "id": 3,
                 "node": "TSFunctionType",
-                "symbols": []
+                "symbols": [
+                  {
+                    "flags": "SymbolFlags(FunctionScopedVariable)",
+                    "id": 2,
+                    "name": "k",
+                    "node": "FormalParameter(k)",
+                    "references": []
+                  }
+                ]
               }
             ],
             "flags": "ScopeFlags(StrictMode | TsConditional)",
@@ -23,7 +31,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "symbols": [
               {
                 "flags": "SymbolFlags(TypeParameter)",
-                "id": 2,
+                "id": 3,
                 "name": "I",
                 "node": "TSTypeParameter(I)",
                 "references": [
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/conditional5.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/conditional5.snap
@@ -16,13 +16,29 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
                     "flags": "ScopeFlags(StrictMode)",
                     "id": 4,
                     "node": "TSFunctionType",
-                    "symbols": []
+                    "symbols": [
+                      {
+                        "flags": "SymbolFlags(FunctionScopedVariable)",
+                        "id": 3,
+                        "name": "arg2",
+                        "node": "FormalParameter(arg2)",
+                        "references": []
+                      }
+                    ]
                   }
                 ],
                 "flags": "ScopeFlags(StrictMode)",
                 "id": 3,
                 "node": "TSFunctionType",
-                "symbols": []
+                "symbols": [
+                  {
+                    "flags": "SymbolFlags(FunctionScopedVariable)",
+                    "id": 2,
+                    "name": "arg",
+                    "node": "FormalParameter(arg)",
+                    "references": []
+                  }
+                ]
               }
             ],
             "flags": "ScopeFlags(StrictMode | TsConditional)",
@@ -31,7 +47,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "symbols": [
               {
                 "flags": "SymbolFlags(TypeParameter)",
-                "id": 2,
+                "id": 4,
                 "name": "I",
                 "node": "TSTypeParameter(I)",
                 "references": [
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/constructor-generics1.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/constructor-generics1.snap
@@ -19,7 +19,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 3,
             "node": "TSConstructorType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 3,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/constructor-generics2.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/constructor-generics2.snap
@@ -33,6 +33,13 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
                     "node_id": 16
                   }
                 ]
+              },
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 3,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
               }
             ]
           }
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/constructor.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/constructor.snap
@@ -19,7 +19,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 3,
             "node": "TSConstructorType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function-generics1.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function-generics1.snap
@@ -19,7 +19,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 3,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 3,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function-generics2.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function-generics2.snap
@@ -33,6 +33,13 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
                     "node_id": 16
                   }
                 ]
+              },
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 3,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
               }
             ]
           }
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function1.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function1.snap
@@ -19,7 +19,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 3,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function2.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/function2.snap
@@ -12,7 +12,22 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 2,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": [
+                  {
+                    "flags": "ReferenceFlags(Type)",
+                    "id": 0,
+                    "name": "arg",
+                    "node_id": 15
+                  }
+                ]
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
@@ -30,14 +45,7 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
         "id": 0,
         "name": "arg",
         "node": "VariableDeclarator(arg)",
-        "references": [
-          {
-            "flags": "ReferenceFlags(Type)",
-            "id": 0,
-            "name": "arg",
-            "node_id": 15
-          }
-        ]
+        "references": []
       },
       {
         "flags": "SymbolFlags(TypeAlias)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/params/array-pattern.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/params/array-pattern.snap
@@ -12,7 +12,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 2,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "a",
+                "node": "FormalParameter(<destructure>)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/params/object-pattern.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/params/object-pattern.snap
@@ -12,7 +12,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 2,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "a",
+                "node": "FormalParameter(<destructure>)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/params/rest-element.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/function/params/rest-element.snap
@@ -12,7 +12,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 2,
             "node": "TSFunctionType",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "a",
+                "node": "BindingRestElement",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/call-generics.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/call-generics.snap
@@ -33,6 +33,13 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
                     "node_id": 17
                   }
                 ]
+              },
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 3,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
               }
             ]
           }
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/call.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/call.snap
@@ -19,7 +19,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 3,
             "node": "TSCallSignatureDeclaration",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/construct-generics.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/construct-generics.snap
@@ -33,6 +33,13 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
                     "node_id": 17
                   }
                 ]
+              },
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 3,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
               }
             ]
           }
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/construct.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/construct.snap
@@ -19,7 +19,15 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio
             "flags": "ScopeFlags(StrictMode)",
             "id": 3,
             "node": "TSConstructSignatureDeclaration",
-            "symbols": []
+            "symbols": [
+              {
+                "flags": "SymbolFlags(FunctionScopedVariable)",
+                "id": 2,
+                "name": "arg",
+                "node": "FormalParameter(arg)",
+                "references": []
+              }
+            ]
           }
         ],
         "flags": "ScopeFlags(StrictMode)",
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method-computed-name.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method-computed-name.snap
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method-generics.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method-generics.snap
diff --git a/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method.snap b/crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaration/signatures/method.snap
diff --git a/tasks/coverage/snapshots/semantic_babel.snap b/tasks/coverage/snapshots/semantic_babel.snap
diff --git a/tasks/coverage/snapshots/semantic_typescript.snap b/tasks/coverage/snapshots/semantic_typescript.snap
diff --git a/tasks/transform_conformance/snapshots/oxc.snap.md b/tasks/transform_conformance/snapshots/oxc.snap.md

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,13 @@ input_file: crates/oxc_semantic/tests/fixtures/typescript-eslint/type-declaratio`
`33`	`33`	`"node_id": 16`
`34`	`34`	`}`
`35`	`35`	`]`
	`36`	`+ },`
	`37`	`+ {`
	`38`	`+ "flags": "SymbolFlags(FunctionScopedVariable)",`
	`39`	`+ "id": 3,`
	`40`	`+ "name": "arg",`
	`41`	`+ "node": "FormalParameter(arg)",`
	`42`	`+ "references": []`
`36`	`43`	`}`
`37`	`44`	`]`
`38`	`45`	`}`