fix(linter/no-empty-file): false positive with empty file with triple slash directive (#12293)

camc314 · camc314 · commit 47fad0e67a55 · 2025-07-15T13:57:31.000Z
diff --git a/crates/oxc_linter/src/rules/unicorn/no_empty_file.rs b/crates/oxc_linter/src/rules/unicorn/no_empty_file.rs
@@ -74,7 +74,9 @@ fn has_triple_slash_directive(ctx: &LintContext<'_>) -> bool {
             continue;
         }
         let text = ctx.source_range(comment.content_span());
-        if text.starts_with("///") {
+
+        // `comment.content_span` doesn't include the leading `//` of the comment
+        if text.starts_with('/') {
             return true;
         }
     }
@@ -110,6 +112,7 @@ fn test() {
         r"(() => {})()",
         "(() => {})();",
         "/* eslint-disable no-empty-file */",
+        r#"/// <reference types="vite/client" />"#,
     ];
 
     let fail = vec![

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,9 @@ fn has_triple_slash_directive(ctx: &LintContext<'_>) -> bool {`
`74`	`74`	`continue;`
`75`	`75`	`}`
`76`	`76`	`let text = ctx.source_range(comment.content_span());`
`77`		`- if text.starts_with("///") {`
	`77`	`+`
	`78`	+ // `comment.content_span` doesn't include the leading `//` of the comment
	`79`	`+ if text.starts_with('/') {`
`78`	`80`	`return true;`
`79`	`81`	`}`
`80`	`82`	`}`
`@@ -110,6 +112,7 @@ fn test() {`
`110`	`112`	`r"(() => {})()",`
`111`	`113`	`"(() => {})();",`
`112`	`114`	`"/* eslint-disable no-empty-file */",`
	`115`	`+ r#"/// <reference types="vite/client" />"#,`
`113`	`116`	`];`
`114`	`117`
`115`	`118`	`let fail = vec![`