wip: skip rules that do not have any relevant node types

Author: camchenry

Cargo.lock

@@ -4,6 +4,7 @@
 use std::{path::Path, rc::Rc, sync::Arc};
 
 use oxc_allocator::Allocator;
+use oxc_ast::ast_kind::AST_TYPE_MAX;
 use oxc_semantic::{AstNode, Semantic};
 
 #[cfg(all(feature = "oxlint2", not(feature = "disable_oxlint2")))]
@@ -25,6 +26,7 @@ mod module_graph_visitor;
 mod module_record;
 mod options;
 mod rule;
+mod rule_runner_impls;
 mod service;
 mod tsgolint;
 mod utils;
@@ -56,7 +58,7 @@ pub use crate::{
     module_record::ModuleRecord,
     options::LintOptions,
     options::{AllowWarnDeny, InvalidFilterKind, LintFilter, LintFilterKind},
-    rule::{RuleCategory, RuleFixMeta, RuleMeta},
+    rule::{RuleCategory, RuleFixMeta, RuleMeta, RuleRunner},
     service::{LintService, LintServiceOptions, RuntimeFileSystem},
     tsgolint::TsGoLintState,
     utils::{read_to_arena_str, read_to_string},
@@ -145,6 +147,9 @@ impl Linter {
         let should_run_on_jest_node =
             ctx_host.plugins().has_test() && ctx_host.frameworks().is_test();
 
+        // Collect rules into a Vec so that we can iterate over the rules multiple times
+        let rules = rules.collect::<Vec<_>>();
+
         // IMPORTANT: We have two branches here for performance reasons:
         //
         // 1) Branch where we iterate over each node, then each rule
@@ -164,9 +169,6 @@ impl Linter {
         //
         // See https://github.com/oxc-project/oxc/pull/6600 for more context.
         if semantic.nodes().len() > 200_000 {
-            // Collect rules into a Vec so that we can iterate over the rules multiple times
-            let rules = rules.collect::<Vec<_>>();
-
             for (rule, ctx) in &rules {
                 rule.run_once(ctx);
             }
@@ -191,23 +193,45 @@ impl Linter {
                 }
             }
         } else {
-            for (rule, ref ctx) in rules {
+            let mut rules_by_ast_type = vec![Vec::new(); AST_TYPE_MAX as usize + 1];
+            let mut rules_any_ast_type = vec![];
+
+            for (rule, ctx) in rules.iter() {
+                if rule.should_run(&ctx_host) {
+                    let (ast_types, all_types) = rule.types_info();
+                    if all_types {
+                        rules_any_ast_type.push((rule, ctx));
+                    } else {
+                        for ty in ast_types {
+                            rules_by_ast_type[ty as usize].push((rule, ctx));
+                        }
+                    }
+                }
+            }
+
+            for (rule, ctx) in rules.iter() {
                 rule.run_once(ctx);
 
                 for symbol in semantic.scoping().symbol_ids() {
                     rule.run_on_symbol(symbol, ctx);
                 }
 
-                for node in semantic.nodes() {
-                    rule.run(node, ctx);
-                }
-
                 if should_run_on_jest_node {
                     for jest_node in iter_possible_jest_call_node(semantic) {
                         rule.run_on_jest_node(&jest_node, ctx);
                     }
                 }
             }
+
+            // Run rules on nodes
+            for node in semantic.nodes() {
+                for (rule, ctx) in &rules_by_ast_type[node.kind().ty() as usize] {
+                    rule.run(node, ctx);
+                }
+                for (rule, ctx) in &rules_any_ast_type {
+                    rule.run(node, ctx);
+                }
+            }
         }
 
         #[cfg(all(feature = "oxlint2", not(feature = "disable_oxlint2")))]

crates/oxc_linter/src/lib.rs

@@ -5,7 +5,7 @@ use std::{fmt, hash::Hash};
 use schemars::{JsonSchema, SchemaGenerator, schema::Schema};
 use serde::{Deserialize, Serialize};
 
-use oxc_semantic::SymbolId;
+use oxc_semantic::{AstTypesBitset, SymbolId};
 
 use crate::{
     AstNode, FixKind,
@@ -66,6 +66,16 @@ pub trait Rule: Sized + Default + fmt::Debug {
     }
 }
 
+pub trait RuleRunner: Rule {
+    /// `AstType`s that rule acts on
+    const NODE_TYPES: &AstTypesBitset;
+    /// `true` if codegen can't figure out what node types rule acts on
+    const ANY_NODE_TYPE: bool;
+
+    fn types_info(&self) -> (&'static AstTypesBitset, bool) {
+        (Self::NODE_TYPES, Self::ANY_NODE_TYPE)
+    }
+}
 pub trait RuleMeta {
     const NAME: &'static str;