refactor(diagnostics): implement Eq and Ord for InfoPosition (#12505)

overlookmotel · overlookmotel · commit 5c33fc706567 · 2025-07-24T17:39:47.000Z
Implement these traits to shorten code elsewhere.
diff --git a/apps/oxlint/src/output_formatter/default.rs b/apps/oxlint/src/output_formatter/default.rs
@@ -134,15 +134,7 @@ mod test_implementation {
 
             self.diagnostics.sort_by_cached_key(|diagnostic| {
                 let info = Info::new(diagnostic);
-                (
-                    info.filename,
-                    info.start.line,
-                    info.start.column,
-                    info.end.line,
-                    info.end.column,
-                    info.rule_id,
-                    info.message,
-                )
+                (info.filename, info.start, info.end, info.rule_id, info.message)
             });
 
             for diagnostic in &self.diagnostics {
diff --git a/crates/oxc_diagnostics/src/reporter.rs b/crates/oxc_diagnostics/src/reporter.rs
@@ -101,7 +101,7 @@ pub struct Info {
     pub rule_id: Option<String>,
 }
 
-#[derive(Debug)]
+#[derive(PartialEq, Eq, PartialOrd, Ord, Debug)]
 pub struct InfoPosition {
     pub line: usize,
     pub column: usize,

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ pub struct Info {`
`101`	`101`	`pub rule_id: Option<String>,`
`102`	`102`	`}`
`103`	`103`
`104`		`-#[derive(Debug)]`
	`104`	`+#[derive(PartialEq, Eq, PartialOrd, Ord, Debug)]`
`105`	`105`	`pub struct InfoPosition {`
`106`	`106`	`pub line: usize,`
`107`	`107`	`pub column: usize,`