refactor(linter): add AriaProperty enum (#10325)

Replaces ARIA strings everywhere with an enum that represents all ARIA properties in a single byte. This should allow us to store this more efficiently in memory and also reduce the executable size.

Author: camchenry

crates/oxc_linter/src/globals.rs

@@ -12,58 +12,182 @@ pub const RESERVED_HTML_TAG: [&str; 16] = [
     "picture", "script", "source", "style", "title", "track",
 ];
 
-/// set of valid ARIA properties from the WAI-ARIA 1.1 specifications.
-/// Reference: <https://www.w3.org/TR/wai-aria/#state_prop_def>
-pub const VALID_ARIA_PROPS: phf::Set<&'static str> = phf_set! {
-    "aria-activedescendant",
-    "aria-atomic",
-    "aria-autocomplete",
-    "aria-busy",
-    "aria-checked",
-    "aria-colcount",
-    "aria-colindex",
-    "aria-colspan",
-    "aria-controls",
-    "aria-current",
-    "aria-describedby",
-    "aria-details",
-    "aria-disabled",
-    "aria-dropeffect",
-    "aria-errormessage",
-    "aria-expanded",
-    "aria-flowto",
-    "aria-grabbed",
-    "aria-haspopup",
-    "aria-hidden",
-    "aria-invalid",
-    "aria-keyshortcuts",
-    "aria-label",
-    "aria-labelledby",
-    "aria-level",
-    "aria-live",
-    "aria-modal",
-    "aria-multiline",
-    "aria-multiselectable",
-    "aria-orientation",
-    "aria-owns",
-    "aria-placeholder",
-    "aria-posinset",
-    "aria-pressed",
-    "aria-readonly",
-    "aria-relevant",
-    "aria-required",
-    "aria-roledescription",
-    "aria-rowcount",
-    "aria-rowindex",
-    "aria-rowspan",
-    "aria-selected",
-    "aria-setsize",
-    "aria-sort",
-    "aria-valuemax",
-    "aria-valuemin",
-    "aria-valuenow",
-    "aria-valuetext"
-};
+const ARIA_ACTIVEDESCENDANT: &str = "aria-activedescendant";
+const ARIA_ATOMIC: &str = "aria-atomic";
+const ARIA_AUTOCOMPLETE: &str = "aria-autocomplete";
+const ARIA_BUSY: &str = "aria-busy";
+const ARIA_BRAILLELABEL: &str = "aria-braillelabel";
+const ARIA_BRAILLEROLEDESCRIPTION: &str = "aria-brailleroledescription";
+const ARIA_CHECKED: &str = "aria-checked";
+const ARIA_COLCOUNT: &str = "aria-colcount";
+const ARIA_COLINDEX: &str = "aria-colindex";
+const ARIA_COLSPAN: &str = "aria-colspan";
+const ARIA_CONTROLS: &str = "aria-controls";
+const ARIA_CURRENT: &str = "aria-current";
+const ARIA_DESCRIBEDBY: &str = "aria-describedby";
+const ARIA_DESCRIPTION: &str = "aria-description";
+const ARIA_DETAILS: &str = "aria-details";
+const ARIA_DISABLED: &str = "aria-disabled";
+const ARIA_DROPEFFECT: &str = "aria-dropeffect";
+const ARIA_ERRORMESSAGE: &str = "aria-errormessage";
+const ARIA_EXPANDED: &str = "aria-expanded";
+const ARIA_FLOWTO: &str = "aria-flowto";
+const ARIA_GRABBED: &str = "aria-grabbed";
+const ARIA_HASPOPUP: &str = "aria-haspopup";
+const ARIA_HIDDEN: &str = "aria-hidden";
+const ARIA_INVALID: &str = "aria-invalid";
+const ARIA_KEYSHORTCUTS: &str = "aria-keyshortcuts";
+const ARIA_LABEL: &str = "aria-label";
+const ARIA_LABELLEDBY: &str = "aria-labelledby";
+const ARIA_LEVEL: &str = "aria-level";
+const ARIA_LIVE: &str = "aria-live";
+const ARIA_MODAL: &str = "aria-modal";
+const ARIA_MULTILINE: &str = "aria-multiline";
+const ARIA_MULTISELECTABLE: &str = "aria-multiselectable";
+const ARIA_ORIENTATION: &str = "aria-orientation";
+const ARIA_OWNS: &str = "aria-owns";
+const ARIA_PLACEHOLDER: &str = "aria-placeholder";
+const ARIA_POSINSET: &str = "aria-posinset";
+const ARIA_PRESSED: &str = "aria-pressed";
+const ARIA_READONLY: &str = "aria-readonly";
+const ARIA_RELEVANT: &str = "aria-relevant";
+const ARIA_REQUIRED: &str = "aria-required";
+const ARIA_ROLEDESCRIPTION: &str = "aria-roledescription";
+const ARIA_ROWCOUNT: &str = "aria-rowcount";
+const ARIA_ROWINDEX: &str = "aria-rowindex";
+const ARIA_ROWSPAN: &str = "aria-rowspan";
+const ARIA_SELECTED: &str = "aria-selected";
+const ARIA_SETSIZE: &str = "aria-setsize";
+const ARIA_SORT: &str = "aria-sort";
+const ARIA_VALUEMAX: &str = "aria-valuemax";
+const ARIA_VALUEMIN: &str = "aria-valuemin";
+const ARIA_VALUENOW: &str = "aria-valuenow";
+const ARIA_VALUETEXT: &str = "aria-valuetext";
+
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum AriaProperty {
+    ActiveDescendant,
+    Atomic,
+    AutoComplete,
+    Busy,
+    BrailleLabel,
+    BrailleRoleDescription,
+    Checked,
+    ColCount,
+    ColIndex,
+    ColSpan,
+    Controls,
+    Current,
+    DescribedBy,
+    Description,
+    Details,
+    Disabled,
+    DropEffect,
+    ErrorMessage,
+    Expanded,
+    FlowTo,
+    Grabbed,
+    HasPopup,
+    Hidden,
+    Invalid,
+    KeyShortcuts,
+    Label,
+    LabelledBy,
+    Level,
+    Live,
+    Modal,
+    Multiline,
+    Multiselectable,
+    Orientation,
+    Owns,
+    Placeholder,
+    PosInSet,
+    Pressed,
+    Readonly,
+    Relevant,
+    Required,
+    RoleDescription,
+    RowCount,
+    RowIndex,
+    RowSpan,
+    Selected,
+    SetSize,
+    Sort,
+    ValueMax,
+    ValueMin,
+    ValueNow,
+    ValueText,
+}
+
+impl TryFrom<&str> for AriaProperty {
+    type Error = ();
+
+    fn try_from(value: &str) -> Result<Self, Self::Error> {
+        match value {
+            ARIA_ACTIVEDESCENDANT => Ok(AriaProperty::ActiveDescendant),
+            ARIA_ATOMIC => Ok(AriaProperty::Atomic),
+            ARIA_AUTOCOMPLETE => Ok(AriaProperty::AutoComplete),
+            ARIA_BUSY => Ok(AriaProperty::Busy),
+            ARIA_BRAILLELABEL => Ok(AriaProperty::BrailleLabel),
+            ARIA_BRAILLEROLEDESCRIPTION => Ok(AriaProperty::BrailleRoleDescription),
+            ARIA_CHECKED => Ok(AriaProperty::Checked),
+            ARIA_COLCOUNT => Ok(AriaProperty::ColCount),
+            ARIA_COLINDEX => Ok(AriaProperty::ColIndex),
+            ARIA_COLSPAN => Ok(AriaProperty::ColSpan),
+            ARIA_CONTROLS => Ok(AriaProperty::Controls),
+            ARIA_CURRENT => Ok(AriaProperty::Current),
+            ARIA_DESCRIBEDBY => Ok(AriaProperty::DescribedBy),
+            ARIA_DESCRIPTION => Ok(AriaProperty::Description),
+            ARIA_DETAILS => Ok(AriaProperty::Details),
+            ARIA_DISABLED => Ok(AriaProperty::Disabled),
+            ARIA_DROPEFFECT => Ok(AriaProperty::DropEffect),
+            ARIA_ERRORMESSAGE => Ok(AriaProperty::ErrorMessage),
+            ARIA_EXPANDED => Ok(AriaProperty::Expanded),
+            ARIA_FLOWTO => Ok(AriaProperty::FlowTo),
+            ARIA_GRABBED => Ok(AriaProperty::Grabbed),
+            ARIA_HASPOPUP => Ok(AriaProperty::HasPopup),
+            ARIA_HIDDEN => Ok(AriaProperty::Hidden),
+            ARIA_INVALID => Ok(AriaProperty::Invalid),
+            ARIA_KEYSHORTCUTS => Ok(AriaProperty::KeyShortcuts),
+            ARIA_LABEL => Ok(AriaProperty::Label),
+            ARIA_LABELLEDBY => Ok(AriaProperty::LabelledBy),
+            ARIA_LEVEL => Ok(AriaProperty::Level),
+            ARIA_LIVE => Ok(AriaProperty::Live),
+            ARIA_MODAL => Ok(AriaProperty::Modal),
+            ARIA_MULTILINE => Ok(AriaProperty::Multiline),
+            ARIA_MULTISELECTABLE => Ok(AriaProperty::Multiselectable),
+            ARIA_ORIENTATION => Ok(AriaProperty::Orientation),
+            ARIA_OWNS => Ok(AriaProperty::Owns),
+            ARIA_PLACEHOLDER => Ok(AriaProperty::Placeholder),
+            ARIA_POSINSET => Ok(AriaProperty::PosInSet),
+            ARIA_PRESSED => Ok(AriaProperty::Pressed),
+            ARIA_READONLY => Ok(AriaProperty::Readonly),
+            ARIA_RELEVANT => Ok(AriaProperty::Relevant),
+            ARIA_REQUIRED => Ok(AriaProperty::Required),
+            ARIA_ROLEDESCRIPTION => Ok(AriaProperty::RoleDescription),
+            ARIA_ROWCOUNT => Ok(AriaProperty::RowCount),
+            ARIA_ROWINDEX => Ok(AriaProperty::RowIndex),
+            ARIA_ROWSPAN => Ok(AriaProperty::RowSpan),
+            ARIA_SELECTED => Ok(AriaProperty::Selected),
+            ARIA_SETSIZE => Ok(AriaProperty::SetSize),
+            ARIA_SORT => Ok(AriaProperty::Sort),
+            ARIA_VALUEMAX => Ok(AriaProperty::ValueMax),
+            ARIA_VALUEMIN => Ok(AriaProperty::ValueMin),
+            ARIA_VALUENOW => Ok(AriaProperty::ValueNow),
+            ARIA_VALUETEXT => Ok(AriaProperty::ValueText),
+            _ => Err(()),
+        }
+    }
+}
+
+/// Returns whether this string is a valid ARIA property.
+///
+/// # Example
+/// - `is_valid_aria_property("aria-label")` => `true`
+/// - `is_valid_aria_property("aria-labelby")` => `false`
+pub fn is_valid_aria_property(name: &str) -> bool {
+    AriaProperty::try_from(name).is_ok()
+}
 
 /// set of valid ARIA role definitions
 /// Reference: <https://www.w3.org/TR/wai-aria/#role_definitions>

crates/oxc_linter/src/rules/jsx_a11y/aria_props.rs

@@ -5,7 +5,7 @@ use oxc_macros::declare_oxc_lint;
 use oxc_span::{GetSpan, Span};
 
 use crate::{
-    AstNode, context::LintContext, globals::VALID_ARIA_PROPS, rule::Rule,
+    AstNode, context::LintContext, globals::is_valid_aria_property, rule::Rule,
     utils::get_jsx_attribute_name,
 };
 
@@ -56,7 +56,7 @@ impl Rule for AriaProps {
         if let AstKind::JSXAttributeItem(JSXAttributeItem::Attribute(attr)) = node.kind() {
             let name = get_jsx_attribute_name(&attr.name);
             let name = name.cow_to_ascii_lowercase();
-            if name.starts_with("aria-") && !VALID_ARIA_PROPS.contains(&name) {
+            if name.starts_with("aria-") && !is_valid_aria_property(&name) {
                 let suggestion = COMMON_TYPOS.get(&name).copied();
                 let diagnostic = aria_props_diagnostic(attr.span, &name, suggestion);