fix(parser): panic when parsing interface with missing implements (#11898)

Author: camc314

crates/oxc_parser/src/js/class.rs

@@ -107,7 +107,7 @@ impl<'a> ParserImpl<'a> {
             type_parameters,
             super_class,
             super_type_parameters,
-            implements,
+            implements.map_or_else(|| self.ast.vec(), |(_, implements)| implements),
             body,
             modifiers.contains_abstract(),
             modifiers.contains_declare(),
@@ -116,9 +116,9 @@ impl<'a> ParserImpl<'a> {
 
     pub(crate) fn parse_heritage_clause(
         &mut self,
-    ) -> (Option<Extends<'a>>, Vec<'a, TSClassImplements<'a>>) {
+    ) -> (Option<Extends<'a>>, Option<(Span, Vec<'a, TSClassImplements<'a>>)>) {
         let mut extends = None;
-        let mut implements = self.ast.vec();
+        let mut implements: Option<(Span, Vec<'a, TSClassImplements<'a>>)> = None;
 
         loop {
             match self.cur_kind() {
@@ -127,20 +127,28 @@ impl<'a> ParserImpl<'a> {
                         self.error(diagnostics::extends_clause_already_seen(
                             self.cur_token().span(),
                         ));
-                    } else if !implements.is_empty() {
+                    } else if implements.is_some() {
                         self.error(diagnostics::extends_clause_must_precede_implements(
                             self.cur_token().span(),
                         ));
                     }
                     extends = Some(self.parse_extends_clause());
                 }
                 Kind::Implements => {
-                    if !implements.is_empty() {
+                    if implements.is_some() {
                         self.error(diagnostics::implements_clause_already_seen(
                             self.cur_token().span(),
                         ));
                     }
-                    implements.extend(self.parse_ts_implements_clause());
+                    let implements_kw_span = self.cur_token().span();
+                    if let Some((_, implements)) = implements.as_mut() {
+                        implements.extend(self.parse_ts_implements_clause());
+                    } else {
+                        implements = Some((
+                            implements_kw_span,
+                            self.ast.vec_from_iter(self.parse_ts_implements_clause()),
+                        ));
+                    }
                 }
                 _ => break,
             }

crates/oxc_parser/src/ts/statement.rs

@@ -199,11 +199,8 @@ impl<'a> ParserImpl<'a> {
             ModifierFlags::DECLARE,
             diagnostics::modifier_cannot_be_used_here,
         );
-        if !implements.is_empty() {
-            self.error(diagnostics::interface_implements(Span::new(
-                implements.first().unwrap().span.start,
-                implements.last().unwrap().span.end,
-            )));
+        if let Some((implements_kw_span, _)) = implements {
+            self.error(diagnostics::interface_implements(implements_kw_span));
         }
         for extend in &extends {
             if !extend.expression.is_entity_name_expression() {

tasks/coverage/misc/fail/oxc-11789-1.ts

@@ -0,0 +1 @@
+interface i<>implements 

tasks/coverage/misc/fail/oxc-11789-2.ts

@@ -0,0 +1 @@
+interface i<>implements K {}

tasks/coverage/snapshots/parser_misc.snap

@@ -1,7 +1,7 @@
 parser_misc Summary:
 AST Parsed     : 43/43 (100.00%)
 Positive Passed: 43/43 (100.00%)
-Negative Passed: 45/45 (100.00%)
+Negative Passed: 47/47 (100.00%)
 
   × Identifier `b` has already been declared
    ╭─[misc/fail/oxc-10159.js:1:22]
@@ -118,6 +118,29 @@ Negative Passed: 45/45 (100.00%)
    ·            ╰── `{` expected
    ╰────
 
+  × TS(1098): Type parameter list cannot be empty.
+   ╭─[misc/fail/oxc-11789-1.ts:1:12]
+ 1 │ interface i<>implements 
+   ·            ──
+   ╰────
+
+  × Unexpected token
+   ╭─[misc/fail/oxc-11789-1.ts:1:25]
+ 1 │ interface i<>implements 
+   ╰────
+
+  × TS(1098): Type parameter list cannot be empty.
+   ╭─[misc/fail/oxc-11789-2.ts:1:12]
+ 1 │ interface i<>implements K {}
+   ·            ──
+   ╰────
+
+  × TS(1176): Interface declaration cannot have 'implements' clause.
+   ╭─[misc/fail/oxc-11789-2.ts:1:14]
+ 1 │ interface i<>implements K {}
+   ·              ──────────
+   ╰────
+
   × Unexpected token
    ╭─[misc/fail/oxc-169.js:2:1]
  1 │ 1<(V=82<<t-j0<(V=$<LBI<(V=ut<I<(V=$<LBI<(V=uIV=82<<t-j0<(V=$<LBI<(V=ut<I<(V=$<LBI<(V<II>

tasks/coverage/snapshots/parser_typescript.snap

@@ -13180,10 +13180,10 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/salsa/private
   help: Try insert a semicolon here
 
   × TS(1176): Interface declaration cannot have 'implements' clause.
-   ╭─[typescript/tests/cases/compiler/interfaceWithImplements1.ts:3:27]
+   ╭─[typescript/tests/cases/compiler/interfaceWithImplements1.ts:3:16]
  2 │ 
  3 │ interface IBar implements IFoo {
-   ·                           ────
+   ·                ──────────
  4 │ }
    ╰────
 
@@ -25475,10 +25475,10 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/salsa/private
    ╰────
 
   × TS(1176): Interface declaration cannot have 'implements' clause.
-    ╭─[typescript/tests/cases/conformance/interfaces/interfaceDeclarations/interfaceThatInheritsFromItself.ts:10:26]
+    ╭─[typescript/tests/cases/conformance/interfaces/interfaceDeclarations/interfaceThatInheritsFromItself.ts:10:15]
   9 │ 
  10 │ interface Bar implements Bar { // error
-    ·                          ───
+    ·               ──────────
  11 │ }
     ╰────
 
@@ -27522,9 +27522,9 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/salsa/private
    ╰────
 
   × TS(1176): Interface declaration cannot have 'implements' clause.
-   ╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration2.ts:1:24]
+   ╭─[typescript/tests/cases/conformance/parser/ecmascript5/InterfaceDeclarations/parserInterfaceDeclaration2.ts:1:13]
  1 │ interface I implements A {
-   ·                        ─
+   ·             ──────────
  2 │ }
    ╰────