feat(linter): load custom JS plugins

Author: camc314

Cargo.lock

@@ -1,7 +1,7 @@
 use std::path::PathBuf;
 
 use bpaf::Bpaf;
-use oxc_linter::{AllowWarnDeny, FixKind, LintPlugins};
+use oxc_linter::{AllowWarnDeny, BuiltinLintPlugins, FixKind, LintPlugins};
 
 use crate::output_formatter::OutputFormat;
 
@@ -328,23 +328,25 @@ impl OverrideToggle {
 
 impl EnablePlugins {
     pub fn apply_overrides(&self, plugins: &mut LintPlugins) {
-        self.react_plugin.inspect(|yes| plugins.set(LintPlugins::REACT, yes));
-        self.unicorn_plugin.inspect(|yes| plugins.set(LintPlugins::UNICORN, yes));
-        self.oxc_plugin.inspect(|yes| plugins.set(LintPlugins::OXC, yes));
-        self.typescript_plugin.inspect(|yes| plugins.set(LintPlugins::TYPESCRIPT, yes));
-        self.import_plugin.inspect(|yes| plugins.set(LintPlugins::IMPORT, yes));
-        self.jsdoc_plugin.inspect(|yes| plugins.set(LintPlugins::JSDOC, yes));
-        self.jest_plugin.inspect(|yes| plugins.set(LintPlugins::JEST, yes));
-        self.vitest_plugin.inspect(|yes| plugins.set(LintPlugins::VITEST, yes));
-        self.jsx_a11y_plugin.inspect(|yes| plugins.set(LintPlugins::JSX_A11Y, yes));
-        self.nextjs_plugin.inspect(|yes| plugins.set(LintPlugins::NEXTJS, yes));
-        self.react_perf_plugin.inspect(|yes| plugins.set(LintPlugins::REACT_PERF, yes));
-        self.promise_plugin.inspect(|yes| plugins.set(LintPlugins::PROMISE, yes));
-        self.node_plugin.inspect(|yes| plugins.set(LintPlugins::NODE, yes));
+        self.react_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::REACT, yes));
+        self.unicorn_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::UNICORN, yes));
+        self.oxc_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::OXC, yes));
+        self.typescript_plugin
+            .inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::TYPESCRIPT, yes));
+        self.import_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::IMPORT, yes));
+        self.jsdoc_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::JSDOC, yes));
+        self.jest_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::JEST, yes));
+        self.vitest_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::VITEST, yes));
+        self.jsx_a11y_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::JSX_A11Y, yes));
+        self.nextjs_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::NEXTJS, yes));
+        self.react_perf_plugin
+            .inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::REACT_PERF, yes));
+        self.promise_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::PROMISE, yes));
+        self.node_plugin.inspect(|yes| plugins.builtin.set(BuiltinLintPlugins::NODE, yes));
 
         // Without this, jest plugins adapted to vitest will not be enabled.
         if self.vitest_plugin.is_enabled() && self.jest_plugin.is_not_set() {
-            plugins.set(LintPlugins::JEST, true);
+            plugins.builtin.set(BuiltinLintPlugins::JEST, true);
         }
     }
 }

apps/oxlint/src/command/lint.rs

@@ -13,8 +13,8 @@ use ignore::{gitignore::Gitignore, overrides::OverrideBuilder};
 use oxc_allocator::AllocatorPool;
 use oxc_diagnostics::{DiagnosticService, GraphicalReportHandler, OxcDiagnostic};
 use oxc_linter::{
-    AllowWarnDeny, Config, ConfigStore, ConfigStoreBuilder, ExternalLinter, InvalidFilterKind,
-    LintFilter, LintOptions, LintService, LintServiceOptions, Linter, Oxlintrc,
+    AllowWarnDeny, Config, ConfigBuilderError, ConfigStore, ConfigStoreBuilder, ExternalLinter,
+    InvalidFilterKind, LintFilter, LintOptions, LintService, LintServiceOptions, Linter, Oxlintrc,
 };
 use rustc_hash::{FxHashMap, FxHashSet};
 use serde_json::Value;
@@ -64,7 +64,7 @@ impl Runner for LintRunner {
             enable_plugins,
             misc_options,
             disable_nested_config,
-            inline_config_options,
+            ref inline_config_options,
             ..
         } = self.options;
 
@@ -203,11 +203,16 @@ impl Runner for LintRunner {
             match ConfigStoreBuilder::from_oxlintrc(false, oxlintrc, external_linter) {
                 Ok(builder) => builder,
                 Err(e) => {
+                    let err = if let ConfigBuilderError::OxcDiagnostic(e) = e {
+                        e
+                    } else {
+                        OxcDiagnostic::error(e.to_string())
+                    };
                     print_and_flush_stdout(
                         stdout,
                         &format!(
                             "Failed to parse configuration file.\n{}\n",
-                            render_report(&handler, &OxcDiagnostic::error(e.to_string()))
+                            render_report(&handler, &err)
                         ),
                     );
                     return CliRunResult::InvalidOptionConfig;
@@ -397,6 +402,7 @@ impl LintRunner {
         paths: &Vec<Arc<OsStr>>,
         external_linter: Option<&ExternalLinter>,
     ) -> Result<FxHashMap<PathBuf, Config>, CliRunResult> {
+        println!("LintRunner::get_nested_configs");
         // TODO(perf): benchmark whether or not it is worth it to store the configurations on a
         // per-file or per-directory basis, to avoid calling `.parent()` on every path.
         let mut nested_oxlintrc = FxHashMap::<&Path, Oxlintrc>::default();
@@ -430,11 +436,16 @@ impl LintRunner {
             {
                 Ok(builder) => builder,
                 Err(e) => {
+                    let err = if let ConfigBuilderError::OxcDiagnostic(e) = e {
+                        e
+                    } else {
+                        OxcDiagnostic::error(e.to_string())
+                    };
                     print_and_flush_stdout(
                         stdout,
                         &format!(
                             "Failed to parse configuration file.\n{}\n",
-                            render_report(handler, &OxcDiagnostic::error(e.to_string()))
+                            render_report(handler, &err)
                         ),
                     );
 

apps/oxlint/src/lint.rs

@@ -15,8 +15,12 @@ description.workspace = true
 
 [features]
 default = []
-ruledocs = ["oxc_macros/ruledocs"] # Enables the `ruledocs` feature for conditional compilation
-language_server = ["oxc_data_structures/rope"] # For the Runtime to support needed information for the language server
+ruledocs = [
+  "oxc_macros/ruledocs",
+] # Enables the `ruledocs` feature for conditional compilation
+language_server = [
+  "oxc_data_structures/rope",
+] # For the Runtime to support needed information for the language server
 
 [lints]
 workspace = true
@@ -48,6 +52,7 @@ constcat = { workspace = true }
 convert_case = { workspace = true }
 cow-utils = { workspace = true }
 fast-glob = { workspace = true }
+futures = { workspace = true }
 globset = { workspace = true }
 indexmap = { workspace = true, features = ["rayon"] }
 itertools = { workspace = true }
@@ -70,6 +75,7 @@ serde = { workspace = true, features = ["derive"] }
 serde_json = { workspace = true }
 simdutf8 = { workspace = true }
 smallvec = { workspace = true }
+tokio = { workspace = true }
 unicode-segmentation = { workspace = true }
 
 [dev-dependencies]