fix(formatter): correct checking of the short argument for CallArguments

Author: Dunqing

crates/oxc_formatter/src/utils/member_chain/simple_argument.rs

@@ -51,6 +51,10 @@ impl<'a, 'b> SimpleArgument<'a, 'b> {
         self.is_simple_impl(0)
     }
 
+    pub fn is_simple_with_depth(&self, depth: u8) -> bool {
+        self.is_simple_impl(depth)
+    }
+
     fn is_simple_impl(&self, depth: u8) -> bool {
         if depth >= 2 {
             return false;

crates/oxc_formatter/src/write/call_arguments.rs

@@ -449,20 +449,20 @@ fn is_simple_ts_type(ty: &TSType<'_>) -> bool {
 fn is_relatively_short_argument(argument: &Expression<'_>) -> bool {
     match argument {
         Expression::BinaryExpression(binary) => {
-            SimpleArgument::from(&binary.left).is_simple()
-                && SimpleArgument::from(&binary.right).is_simple()
+            SimpleArgument::from(&binary.left).is_simple_with_depth(1)
+                && SimpleArgument::from(&binary.right).is_simple_with_depth(1)
         }
         Expression::LogicalExpression(logical) => {
-            SimpleArgument::from(&logical.left).is_simple()
-                && SimpleArgument::from(&logical.right).is_simple()
+            SimpleArgument::from(&logical.left).is_simple_with_depth(1)
+                && SimpleArgument::from(&logical.right).is_simple_with_depth(1)
         }
         Expression::TSAsExpression(expr) => {
             is_simple_ts_type(&expr.type_annotation)
-                && SimpleArgument::from(&expr.expression).is_simple()
+                && SimpleArgument::from(&expr.expression).is_simple_with_depth(1)
         }
         Expression::TSSatisfiesExpression(expr) => {
             is_simple_ts_type(&expr.type_annotation)
-                && SimpleArgument::from(&expr.expression).is_simple()
+                && SimpleArgument::from(&expr.expression).is_simple_with_depth(1)
         }
         Expression::RegExpLiteral(_) => true,
         Expression::CallExpression(call) => match call.arguments.len() {

crates/oxc_formatter/tests/fixtures/ts/arguments/non-short-argument.ts

@@ -0,0 +1,27 @@
+setTimeout(
+  () => {
+    //
+  },
+  timeout * Math.pow(1)
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  true || isFinite(Infinity)
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  call(f) as any
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  call(f) satisfies any
+);

crates/oxc_formatter/tests/fixtures/ts/arguments/non-short-argument.ts.snap

@@ -0,0 +1,62 @@
+---
+source: crates/oxc_formatter/tests/fixtures/mod.rs
+---
+==================== Input ====================
+setTimeout(
+  () => {
+    //
+  },
+  timeout * Math.pow(1)
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  true || isFinite(Infinity)
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  call(f) as any
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  call(f) satisfies any
+);
+
+==================== Output ====================
+setTimeout(
+  () => {
+    //
+  },
+  timeout * Math.pow(1),
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  true || isFinite(Infinity),
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  call(f) as any,
+);
+
+setTimeout(
+  () => {
+    //
+  },
+  call(f) satisfies any,
+);
+
+===================== End =====================