Skip to content

Commit 8d99f6d

Browse files
overlookmoteloverlookmotel
committed
test(linter/plugins): improve ESLint compat tests
1 parent 4a4fce8 commit 8d99f6d

File tree

3 files changed

+21
-24
lines changed

3 files changed

+21
-24
lines changed

‎apps/oxlint/test/fixtures/definePlugin/plugin.js‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { sep } from 'node:path';
22
import { definePlugin } from '../../../dist/index.js';
33

4-
// `loc` field is required for ESLint.
5-
// TODO: Remove this workaround when AST nodes have a `loc` field.
4+
// `loc` is required for ESLint
65
const SPAN = {
76
start: 0,
87
end: 0,
@@ -26,7 +25,7 @@ const createRule = {
2625
Identifier(node) {
2726
context.report({
2827
message: `ident visit fn "${node.name}":\nfilename: ${relativePath(context.filename)}`,
29-
node: { ...SPAN, ...node },
28+
node,
3029
});
3130
},
3231
};
@@ -72,7 +71,7 @@ const createOnceRule = {
7271
message: `ident visit fn "${node.name}":\n`
7372
+ `identNum: ${identNum}\n`
7473
+ `filename: ${relativePath(context.filename)}`,
75-
node: { ...SPAN, ...node },
74+
node,
7675
});
7776
},
7877
after() {
@@ -123,7 +122,7 @@ const createOnceBeforeFalseRule = {
123122
context.report({
124123
message: `ident visit fn "${node.name}":\n`
125124
+ `filename: ${relativePath(context.filename)}`,
126-
node: { ...SPAN, ...node },
125+
node,
127126
});
128127
},
129128
after() {
@@ -153,7 +152,7 @@ const createOnceBeforeOnlyRule = {
153152
context.report({
154153
message: `ident visit fn "${node.name}":\n`
155154
+ `filename: ${relativePath(context.filename)}`,
156-
node: { ...SPAN, ...node },
155+
node,
157156
});
158157
},
159158
};
@@ -167,7 +166,7 @@ const createOnceAfterOnlyRule = {
167166
context.report({
168167
message: `ident visit fn "${node.name}":\n`
169168
+ `filename: ${relativePath(context.filename)}`,
170-
node: { ...SPAN, ...node },
169+
node,
171170
});
172171
},
173172
after() {
@@ -188,7 +187,7 @@ const createOnceNoHooksRule = {
188187
context.report({
189188
message: `ident visit fn "${node.name}":\n`
190189
+ `filename: ${relativePath(context.filename)}`,
191-
node: { ...SPAN, ...node },
190+
node,
192191
});
193192
},
194193
};

‎apps/oxlint/test/fixtures/definePlugin_and_defineRule/plugin.js‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { sep } from 'node:path';
22
import { definePlugin, defineRule } from '../../../dist/index.js';
33

4-
// `loc` field is required for ESLint.
5-
// TODO: Remove this workaround when AST nodes have a `loc` field.
4+
// `loc` is required for ESLint
65
const SPAN = {
76
start: 0,
87
end: 0,
@@ -26,7 +25,7 @@ const createRule = defineRule({
2625
Identifier(node) {
2726
context.report({
2827
message: `ident visit fn "${node.name}":\nfilename: ${relativePath(context.filename)}`,
29-
node: { ...SPAN, ...node },
28+
node,
3029
});
3130
},
3231
};
@@ -71,7 +70,7 @@ const createOnceRule = defineRule({
7170
message: `ident visit fn "${node.name}":\n`
7271
+ `identNum: ${identNum}\n`
7372
+ `filename: ${relativePath(context.filename)}`,
74-
node: { ...SPAN, ...node },
73+
node,
7574
});
7675
},
7776
after() {
@@ -122,7 +121,7 @@ const createOnceBeforeFalseRule = defineRule({
122121
context.report({
123122
message: `ident visit fn "${node.name}":\n`
124123
+ `filename: ${relativePath(context.filename)}`,
125-
node: { ...SPAN, ...node },
124+
node,
126125
});
127126
},
128127
after() {
@@ -152,7 +151,7 @@ const createOnceBeforeOnlyRule = defineRule({
152151
context.report({
153152
message: `ident visit fn "${node.name}":\n`
154153
+ `filename: ${relativePath(context.filename)}`,
155-
node: { ...SPAN, ...node },
154+
node,
156155
});
157156
},
158157
};
@@ -166,7 +165,7 @@ const createOnceAfterOnlyRule = defineRule({
166165
context.report({
167166
message: `ident visit fn "${node.name}":\n`
168167
+ `filename: ${relativePath(context.filename)}`,
169-
node: { ...SPAN, ...node },
168+
node,
170169
});
171170
},
172171
after() {
@@ -187,7 +186,7 @@ const createOnceNoHooksRule = defineRule({
187186
context.report({
188187
message: `ident visit fn "${node.name}":\n`
189188
+ `filename: ${relativePath(context.filename)}`,
190-
node: { ...SPAN, ...node },
189+
node,
191190
});
192191
},
193192
};

‎apps/oxlint/test/fixtures/defineRule/plugin.js‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { sep } from 'node:path';
22
import { defineRule } from '../../../dist/index.js';
33

4-
// `loc` field is required for ESLint.
5-
// TODO: Remove this workaround when AST nodes have a `loc` field.
4+
// `loc` is required for ESLint
65
const SPAN = {
76
start: 0,
87
end: 0,
@@ -26,7 +25,7 @@ const createRule = defineRule({
2625
Identifier(node) {
2726
context.report({
2827
message: `ident visit fn "${node.name}":\nfilename: ${relativePath(context.filename)}`,
29-
node: { ...SPAN, ...node },
28+
node,
3029
});
3130
},
3231
};
@@ -71,7 +70,7 @@ const createOnceRule = defineRule({
7170
message: `ident visit fn "${node.name}":\n`
7271
+ `identNum: ${identNum}\n`
7372
+ `filename: ${relativePath(context.filename)}`,
74-
node: { ...SPAN, ...node },
73+
node,
7574
});
7675
},
7776
after() {
@@ -122,7 +121,7 @@ const createOnceBeforeFalseRule = defineRule({
122121
context.report({
123122
message: `ident visit fn "${node.name}":\n`
124123
+ `filename: ${relativePath(context.filename)}`,
125-
node: { ...SPAN, ...node },
124+
node,
126125
});
127126
},
128127
after() {
@@ -152,7 +151,7 @@ const createOnceBeforeOnlyRule = defineRule({
152151
context.report({
153152
message: `ident visit fn "${node.name}":\n`
154153
+ `filename: ${relativePath(context.filename)}`,
155-
node: { ...SPAN, ...node },
154+
node,
156155
});
157156
},
158157
};
@@ -166,7 +165,7 @@ const createOnceAfterOnlyRule = defineRule({
166165
context.report({
167166
message: `ident visit fn "${node.name}":\n`
168167
+ `filename: ${relativePath(context.filename)}`,
169-
node: { ...SPAN, ...node },
168+
node,
170169
});
171170
},
172171
after() {
@@ -187,7 +186,7 @@ const createOnceNoHooksRule = defineRule({
187186
context.report({
188187
message: `ident visit fn "${node.name}":\n`
189188
+ `filename: ${relativePath(context.filename)}`,
190-
node: { ...SPAN, ...node },
189+
node,
191190
});
192191
},
193192
};

0 commit comments

Comments
 (0)